-
Notifications
You must be signed in to change notification settings - Fork 98
Add missing codegen names #4151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4e4f667
to
bb5a8d2
Compare
bb5a8d2
to
0b9921b
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
2 similar comments
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I skimmed through those, and it looks good. When do we decide on data
vs result
? And is this a breaking change?
@pquentin Thanks for the quick review. I used For Java and .NET it's a breaking change, yes. But I think last time @l-trotta was fine with merging this to 8.18+ as long as it does not go to 8.17. I'm personally fine with only adding it to 9.0, if that works better for everybody. |
@flobernd honestly I'd rather keep this for 9, 31 breaking changes is too many |
Absolutely no problem. 9.0 is fine. I currently use a generic fallback name which I continue to emit it for a while as an deprecated alias property for the new names. Maybe that's an option for Java as well to avoid introducing a hard breaking change. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-4151-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 383a7a765c77197161147be1fb6d8e7a8e3a1a0c
# Push it to GitHub
git push --set-upstream origin backport-4151-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0 Then, create a pull request where the |
As titled.