Skip to content

Enforce globally unique type names #4377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Conversation

pquentin
Copy link
Member

No description provided.

Comment on lines -87 to -89

export class Input {}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new check caught this unused type.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
watcher.ack_watch 🟢 1/1 1/1
watcher.activate_watch 🟢 1/1 1/1
watcher.deactivate_watch 🟢 1/1 1/1
watcher.delete_watch 🟢 2/2 2/2
watcher.execute_watch 🟢 7/7 7/7
watcher.get_settings Missing test Missing test
watcher.get_watch 🟢 9/9 9/9
watcher.put_watch 🔴 29/38 38/38
watcher.query_watches Missing test Missing test
watcher.start 🟢 1/1 1/1
watcher.stats 🟢 1/1 1/1
watcher.stop 🟢 1/1 1/1
watcher.update_settings Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
watcher.ack_watch 🟢 1/1 1/1
watcher.activate_watch 🟢 1/1 1/1
watcher.deactivate_watch 🟢 1/1 1/1
watcher.delete_watch 🟢 2/2 2/2
watcher.execute_watch 🟢 7/7 7/7
watcher.get_settings Missing test Missing test
watcher.get_watch 🟢 9/9 9/9
watcher.put_watch 🔴 29/38 38/38
watcher.query_watches Missing test Missing test
watcher.start 🟢 1/1 1/1
watcher.stats 🟢 1/1 1/1
watcher.stop 🟢 1/1 1/1
watcher.update_settings Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit e0bb763 into main May 16, 2025
10 checks passed
@pquentin pquentin deleted the enforce-globally-unique-type-names branch May 16, 2025 21:48
github-actions bot pushed a commit that referenced this pull request May 16, 2025
github-actions bot pushed a commit that referenced this pull request May 16, 2025
github-actions bot pushed a commit that referenced this pull request May 16, 2025
pquentin added a commit that referenced this pull request May 16, 2025
(cherry picked from commit e0bb763)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request May 16, 2025
(cherry picked from commit e0bb763)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request May 16, 2025
(cherry picked from commit e0bb763)

Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants