Skip to content

Fix type of shard_id #4384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

Fix type of shard_id #4384

merged 1 commit into from
May 21, 2025

Conversation

flobernd
Copy link
Member

As titled.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
search 🔴 2316/2401 2384/2385
snapshot.cleanup_repository 🟢 3/3 3/3
snapshot.clone 🟢 5/5 5/5
snapshot.create_repository 🔴 24/29 29/29
snapshot.create 🟢 29/29 29/29
snapshot.delete_repository 🟢 10/10 10/10
snapshot.delete 🔴 21/23 23/23
snapshot.get_repository 🔴 19/19 7/19
snapshot.get 🟢 13/13 13/13
snapshot.repository_analyze Missing test Missing test
snapshot.repository_verify_integrity Missing test Missing test
snapshot.restore 🟢 5/5 5/5
snapshot.status 🟢 2/2 2/2
snapshot.verify_repository 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

@flobernd flobernd merged commit 6654d81 into main May 21, 2025
21 checks passed
@flobernd flobernd deleted the fix-shard-id-typing branch May 21, 2025 07:17
github-actions bot pushed a commit that referenced this pull request May 21, 2025
(cherry picked from commit 6654d81)
github-actions bot pushed a commit that referenced this pull request May 21, 2025
(cherry picked from commit 6654d81)
github-actions bot pushed a commit that referenced this pull request May 21, 2025
(cherry picked from commit 6654d81)
flobernd added a commit that referenced this pull request May 21, 2025
(cherry picked from commit 6654d81)

Co-authored-by: Florian Bernd <[email protected]>
flobernd added a commit that referenced this pull request May 21, 2025
(cherry picked from commit 6654d81)

Co-authored-by: Florian Bernd <[email protected]>
flobernd added a commit that referenced this pull request May 21, 2025
(cherry picked from commit 6654d81)

Co-authored-by: Florian Bernd <[email protected]>
github-actions bot pushed a commit that referenced this pull request May 21, 2025
(cherry picked from commit 6654d81)
flobernd added a commit that referenced this pull request May 21, 2025
(cherry picked from commit 6654d81)

Co-authored-by: Florian Bernd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants