-
Notifications
You must be signed in to change notification settings - Fork 97
Adds custom InferenceEndpointInfo class for JinaAI #4391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-4391-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6e9264533e8ea359ea68f6af8efdfa4da916d323
# Push it to GitHub
git push --set-upstream origin backport-4391-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-4391-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6e9264533e8ea359ea68f6af8efdfa4da916d323
# Push it to GitHub
git push --set-upstream origin backport-4391-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18 Then, create a pull request where the |
* Adds custom InferenceEndpointInfo class for JinaAI. * Format fix. (cherry picked from commit 6e92645)
* Adds custom InferenceEndpointInfo class for JinaAI. * Format fix. (cherry picked from commit 6e92645) Co-authored-by: István Zoltán Szabó <[email protected]>
* Adds custom InferenceEndpointInfo class for JinaAI. * Format fix.
* Adds custom InferenceEndpointInfo class for JinaAI. * Format fix.
Overview
The Response Attributes section of the reference documentation currently displays the
task_types
defined in theTaskType
enum used by theInferenceEndpointInfo
class. However,InferenceEndpointInfo
is not specific to any particular inference API integration — it lists all available task types, not just those relevant to the specific integration being documented (see screenshot below).Link to docs
The screenshot shows the Response Attributes section of the JinaAI integration documentation. JinaAI supports only two task types:
rerank
andtext_embedding
, which are correctly listed under path parameters.This PR introduces a new
TaskTypeJinaAi
enum that includes only the relevant task types and references it in the newly addedInferenceEndpointInfoJinaAI
class. As a result, the documentation will now accurately display only the supported task types for this integration — even in the Response Attributes section.