Skip to content

Add Request Headers to bypass security gates #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

Dakumo
Copy link

@Dakumo Dakumo commented Mar 13, 2025

We have everything which is not necassarily needed to be public behind a security gate which can be bypassed by adding a header to the request.

So I extended the provider to handle headers...

maybe the config should look different... but my go coding skills are very basic

Idea from me:

 headers = {
    "X-Custom-Header" = "CustomValue"
  }

Currently you can add headers like:

headers = ["X-Custom-Header:CustomValue"]

Copy link

cla-checker-service bot commented Mar 13, 2025

💚 CLA has been signed

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this in. Can we update the schema attribute to be a map rather than require the key:value formatting.

@Dakumo
Copy link
Author

Dakumo commented Apr 16, 2025

@tobio sorry for the long delay... merged your stuff in my branch

thanks for your support here! :)

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are you able to add a changelog entry for this PR too?

I strongly suspect the CLA checker if failing due to these two unverified commits. You should be able to either rewrite the author of those commits to use an email associated with your Github account, or add the email used in those commits to your Github account.

image

@Dakumo
Copy link
Author

Dakumo commented Apr 28, 2025

hi there,

sorry for the delay... i just fix the issue about the verified commits...

and added information to the changelog.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants