Add optional preventInitialBackfill for SLO API #1071
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will address #1070 |
kdelemme
reviewed
Mar 21, 2025
I think the generated settings model found at generated/slo/model_settings.go is still missing a final component here, but that file is generated by OpenAPI so we probably have a change to make in our open API docs, or we need to re-run the generation script there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for this option are here: https://www.elastic.co/docs/api/doc/serverless/operation/operation-createsloop#operation-createsloop-body-application-json-settings-preventinitialbackfill
I've not done any Terraform additions like this one, so there is a good chance the syntax here is wrong — I see that this new setting likely needs to be added in a few additional places to make use of it after it's been added to the schema, so I'd appreciate guidance on where that needs to happen, exactly.
At any rate, it would be great to add this field, and as it's a new, optional field, it shouldn't have any breaking change consequences whatsoever.
UPDATE: I re-generated the SLO model files with openapi-generator, hoping it would only produce a small scope of changes in those files. It seems to have produced a LOT of changes, so I'll wait for guidance on how to handle that.