-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Load modules lazily and only if needed #14453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
commented
Apr 26, 2025
josevalim
commented
Apr 26, 2025
josevalim
commented
Apr 26, 2025
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this pull request, Elixir would load modules as soon as
they were defined. However, because Erlang code loading
happens within a single process (the code server), this would
make it a bottleneck, reducing the amount of parallelization.
This pull request makes it so modules are loaded lazily. This
reduces the pressure on the code server, making compilation
up to 2x faster for large projects, and also reduces the amount
of overall work done.
Implementation wise, the parallel compiler already acts as a
mechanism to resolve modules during compilation, so we build
on that. This has the additional benefit of making compilation more
consistent:
Code.ensure_loaded
will be less dependent on theorder code is compiled.
The only potential regression in this approach happens if you
have
@on_load
callbacks which depends on other modulesdefined in the same project and is loaded at compile-time.
Setting
@compile {:autoload, true}
addresses those casesin a forward and backwards compatible manner.