Skip to content

Add haskell-cabal-mode to supported modes #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

alanz
Copy link
Contributor

@alanz alanz commented Aug 16, 2023

@alanz alanz requested a review from michaelpj August 16, 2023 22:09
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, seems right!

@michaelpj
Copy link
Collaborator

have you tried this, OOI?

@alanz
Copy link
Contributor Author

alanz commented Aug 17, 2023

have you tried this, OOI?

Nope, I need to tweak my config to load the new one, and was already using an emacs instance.

@alanz
Copy link
Contributor Author

alanz commented Aug 17, 2023

And it looks like the normal windows failure, will merge

@alanz alanz merged commit 918ffa2 into emacs-lsp:master Aug 17, 2023
@alanz
Copy link
Contributor Author

alanz commented Aug 17, 2023

And it does not work for me, but I think we need haskell.plugin.cabal.globalOn and haskell.plugin.cabal.completionOn.

https://github.com/haskell/vscode-haskell/blob/4a262a5f0e46b65ffc6eab4f604e0d2c52813612/package.json#L224C10-L235

@alanz alanz deleted the cabal-support branch August 17, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants