Skip to content

Fix for starting pthreads when -sENVIRONMENT=worker #21993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2024
Merged

Fix for starting pthreads when -sENVIRONMENT=worker #21993

merged 1 commit into from
May 23, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented May 23, 2024

Fixes: #21989

@sbc100 sbc100 requested review from kripken and dschuff May 23, 2024 20:18
kripken
kripken reviewed May 23, 2024
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a fix here, only a test?

@sbc100
Copy link
Collaborator Author

sbc100 commented May 23, 2024

I don't see a fix here, only a test?

Sorry, updated.

@sbc100 sbc100 merged commit e2cf42e into emscripten-core:main May 23, 2024
29 checks passed
@sbc100 sbc100 deleted the pthread_worker branch May 23, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken left review comments

@dschuff dschuff dschuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pthread workers fail to run when ENVIRONMENT=worker only
3 participants
@sbc100 @kripken @dschuff