Formalize URLPatternsTestCase #5703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpkilby
force-pushed
the
urlpatterns-testcase
branch
3 times, most recently
from
c8286c1 to
683f1f4
Compare
auvipy
reviewed
Dec 23, 2017
| """ | ||
| url = reverse('account-list') | ||
| response = self.client.get(url, format='json') | ||
| self.assertEqual(response.status_code, status.HTTP_200_OK) |
There was a problem hiding this comment.
how about using pytest style asserts?
There was a problem hiding this comment.
Consistency with the other test case docs. That said, the testing doc does use a mix of both pytest and unittest assertions, although I'd probably opt for the latter given that they're part of the standard library.
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
* Add formalized URLPatternsTestCase * Update versioning tests w/ new URLPatternsTestCase * Cleanup router tests urlpatterns * Add docs for URLPatternsTestCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working on #5609, I found myself reusing the
URLPatternsTestCasefrom the API versioning tests. This PR formalizes it with tests and docs, as well as refactoring the router tests (per #5609). If we don't want to formalize this, an alternative would be to just move this under thetests.utilsmodule, and use it internally.