Use a more lenient dependency version range specification for pygments #8857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Evidently I didn't test these changes well enough, my apologies :/ I'll look into the test case failures (and some deprecation warnings about version constraints) soon. |
jayaddison
commented
Jan 25, 2023
| @@ -41,7 +41,7 @@ | |||
| </code></pre> | |||
| <p>indented</p> | |||
| <h2 id="hash-style-header">hash style header</h2> | |||
| <div class="highlight"><pre><span></span><span class="p">[{</span><span class="w"></span><br /><span class="w"> </span><span class="nt">"alpha"</span><span class="p">:</span><span class="w"> </span><span class="mi">1</span><span class="p">,</span><span class="w"></span><br /><span class="w"> </span><span class="nt">"beta"</span><span class="p">:</span><span class="w"> </span><span class="s2">"this is a string"</span><span class="w"></span><br /><span class="p">}]</span><span class="w"></span><br /></pre></div> | |||
| <div class="highlight"><pre><span></span><span class="p">[{</span><br /><span class="w"> </span><span class="nt">"alpha"</span><span class="p">:</span><span class="w"> </span><span class="mi">1</span><span class="p">,</span><br /><span class="w"> </span><span class="nt">"beta"</span><span class="p">:</span><span class="w"> </span><span class="s2">"this is a string"</span><br /><span class="p">}]</span><br /></pre></div> | |||
There was a problem hiding this comment.
Note: this test expectation seems to be relatively tightly coupled to the installed pygments dependency version.
|
I didn't feel highly confident in the implications of this change, and am closing the pull request as stale. Feel free to recover and merge the changes if they're useful; please double-check for any side-effects though, since I wasn't diligent about that here. |
jayaddison
deleted the
pr-8530-followup/unpin-pygments-dependency-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Between
pygmentsv2.12.0 and v2.13.0, pygments/pygments@147b22f adjusted the way that whitespace is produced in HTML documents.This caused a
django-rest-frameworkunit test to begin failing, which was resolved in #8530 by configuring a specific dependency version (pin) onpygments==2.12.0.This changeset restores the previous lower-bound-and-beyond (albeit within major) version range for
pygmentsand resolves the unit test failure by collecting and concatenating string content from within the HTML produced bypygments(including nested elements).Refs #8530.