Add documentation about how to transform factory request to DRF request #9380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @carltongibson! Is something like that the documentation you had in mind? |
There was a problem hiding this comment.
Hi @mgaligniana, it's similar!
I think people do this when they're testing individual view methods, without going via dispatch.
So, I'd be inclined to say, and show, that. I.e. what you have plus initial() and calling a (fictional) view method, which would be the point of the test.
Make sense?
But, yes, great.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
auvipy
reviewed
Apr 28, 2025
docs/api-guide/testing.md
Outdated
| @@ -102,6 +102,20 @@ This means that setting attributes directly on the request object may not always | |||
| request.user = user | |||
| response = view(request) | |||
|
|
|||
| In case you want to test the request having a REST famework's `Request` you have to transform it by-hand before: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi there!
As there were many issues opened around this topic: "
APIRequestFactorydoes not return aRequestobject" I think it would be worth to have a place in the documentation where explains it.Following the Tom's comment in the last issue #6488 (comment):
*Past issues related: #4440 and #3608
This is what my proposal looks like:
I've also added a test to follow the Carlton's comment #6488 (comment)
Thank you!