Fixes no migrate #114
Merged
Fixes no migrate #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any chance of this getting reviewed and merged? |
|
@danmoore2205 I have it on good authority that @mushyy will be providing the requisite information around this PR tomorrow that will allow me to merge, so it will hopefully be released by the end of the week. Apologies for the delay, both in getting the fix merged and in getting back to you. |
|
Awesome. Thanks to both of you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets migration command as
nilrather than''because''still triggers a migration if set in ey.yml rather than overriding.Testing Done before Fix
--no-migrateor--migrate- Previous deploy command was usedwith migration: "rake db:seed --trace"..--migratecommand - command was used by the deploywith migration: "rake db:migrate --trace".--no-migrateoption - migration was still triggerd output aswith migration: ''without migrationTesting Done After Fix
--no-migrateor--migrate- Previous deploy command was usedwith migration: "rake db:seed --trace"..--no-migrate- no migration command was sent out put waswithout migrationwithout migration--migratecommand - command was used by the deploywith migration: "rake db:migrate --trace".