CaptivePortalAdvanced example doesn't call setContentLength

[krebbi]

Basic Infos

Hardware

Hardware: ESP-12E
Core Version: 2.1.0

Description

this returns an empty response since 2.1.0:

ESP8266WebServer webServer(80);
webServer.sendHeader("Cache-Control", "no-cache, no-store, must-revalidate");
webServer.sendHeader("Pragma", "no-cache");
webServer.sendHeader("Expires", "-1");
webServer.send(200, "text/html", "");
webServer.sendContent(
""
""
"

My HTML

"
""
);
webServer.client().stop();

but this works:

ESP8266WebServer webServer(80);
webServer.sendHeader("Cache-Control", "no-cache, no-store, must-revalidate");
webServer.sendHeader("Pragma", "no-cache");
webServer.sendHeader("Expires", "-1");
webServer.send(200, "text/html", "

My HTML

");

Settings in IDE

Module: NodeMCU 1.0
Flash Size: 4MB/
CPU Frequency: 80Mhz
Flash Mode: ?
Flash Frequency: ?
Upload Using: SERIAL
Reset Method: ?

Sketch

see above

[igrr]

If you intend to send more than once, you need to supply content length or let WebServer know that it is undefined. So before calling send the first time, call server.setContentLength( length ); or server.setContentSize(CONTENT_LENGTH_UNKNOWN) if you don't know it upfront. I wouldn't recommend using CONTENT_LENGTH_UNKNOWN because in this case there will be good chance that server has to close TCP connection actively, which is bad for heap usage. Better calculate the content length and pass it to the server, so that the client knows when the all data is received.

[krebbi]

which version you are working with?
I get
'class ESP8266WebServer' has no member named 'setContentSize'
when trying your approach

[igrr]

Sorry, that was a typo — the function is called setContentLength: https://github.com/esp8266/Arduino/blob/master/libraries/ESP8266WebServer/src/ESP8266WebServer.h#L114

I'm using the latest git version, but the function should be present both in latest stable (2.1.0) and staging (2.1.0-rc2).

[krebbi]

that works, thx!

maybe you should update the CaptivePortalAdvanced Example accordingly.