getCoreVersion reports 00000000 on Windows

[tablatronix]

Is this normal ? Is there something wrong with my platform environment ?

[davisonja]

Are you using the latest version from git, or the latest release package?

…

On Wed, Sep 27, 2017 at 9:12 AM, Shawn A ***@***.***> wrote: Is this normal ? Is there something wrong with my platform environment ? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3657>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAN_Az-01q9dOL-0dk3nOrRMzl7wRB8cks5smVqzgaJpZM4Pk0KX> .

[tablatronix]

ahhhhh, I am using platformio staging, which uses repo not release.

So this is normal I assume

[davisonja]

I believe the coreversion gets computed and stored as part of the release build process, so this would be expected for repo usage. I haven't looked, so I'm not sure how simple it would be to change that, but if people are using direct from repo it might be useful if it could be something more meaningful (so you can actually tell the version from code, which I presume is the aim :)

…

On Wed, Sep 27, 2017 at 9:34 AM, Shawn A ***@***.***> wrote: ahhhhh, I am using platformio staging, which uses repo not release. So this is normal I assume — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3657 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAN_AywyAXsWd9TKKpQPit9z135yGGXIks5smV_TgaJpZM4Pk0KX> .

[igrr]

It should work for git version, if you are using Arduino IDE. There is a hook in platform.txt which launches git to figure out the version. Might be something that hasn't been ported over to platformio build script.

…

On Wed, Sep 27, 2017, 04:38 Julian Davison ***@***.***> wrote: I believe the coreversion gets computed and stored as part of the release build process, so this would be expected for repo usage. I haven't looked, so I'm not sure how simple it would be to change that, but if people are using direct from repo it might be useful if it could be something more meaningful (so you can actually tell the version from code, which I presume is the aim :) On Wed, Sep 27, 2017 at 9:34 AM, Shawn A ***@***.***> wrote: > ahhhhh, I am using platformio staging, which uses repo not release. > > So this is normal I assume > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#3657 (comment)>, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AAN_AywyAXsWd9TKKpQPit9z135yGGXIks5smV_TgaJpZM4Pk0KX > > . > — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3657 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEJceo78FE_oSVVD6HaOFbioIW9Ee-0mks5smWCsgaJpZM4Pk0KX> .

[davisonja]

Ah, okay. The version I currently have in operation has ## windows-compatible version may be added later which is why it's not done that for me using Windows :)

[tablatronix]

I see the hook, let me see if i can figure something out with platformio

[tablatronix]

Looks like I am having issues with this on osx platformio with release
ARDUINO_ESP8266_GIT_VER

[d-a-v]

I ran into this too.
I just discovered that, from inside core/esp8266/*.cpp
#include <core_version.h> is well behaving
#include "core_version.h" is not
The default file with generic default value lives in the same directory, the other one is generated by platform.txt's recipes in arduino's os-dependant temporary directory. I don't know details about platformio.