Skip to content

Missed typed DEBUGV error/warning message in write function from EEPROM.cpp  #7933

Closed
@nedondev

Description

@nedondev

Basic Infos

  • [X ] This issue complies with the issue POLICY doc.
  • [X ] I have read the documentation at readthedocs and the issue is not addressed there.
  • [X ] I have tested that the issue is present in current master branch (aka latest git).
  • [X ] I have searched the issue tracker for a similar issue.
  • [X ] If there is a stack dump, I have decoded it.
  • [X ] I have filled out all fields below.

Platform

  • Hardware: [-]
  • Core Version: [2.7.4]
  • Development Env: [other]
  • Operating System: [Windows]

Settings in IDE

  • Module: [Generic ESP8266 Module|Wemos D1 mini r2|Nodemcu|other]
  • Flash Mode: [other]
  • Flash Size: [4MB/1MB]
  • lwip Variant: [v1.4|v2 Lower Memory|Higher Bandwidth]
  • Reset Method: [ck|nodemcu]
  • Flash Frequency: [40Mhz]
  • CPU Frequency: [80Mhz|160MHz]
  • Upload Using: [OTA|SERIAL]
  • Upload Speed: [115200|other] (serial upload only)

Problem Description

I just read source code for learning about how EEPROM work then I found seem to be
missed typed DEBUG message at Line 113 in EEPROM.cpp file. Should change from
DEBUGV("EEPROMClass::read without ::begin\n");
to
DEBUGV("EEPROMClass::write without ::begin\n");

libraries/EEPROM/EEPROM.cpp code snipped

void **EEPROMClass::write**(int const address, uint8_t const value) {
  if (address < 0 || (size_t)address >= _size) {
    DEBUGV("EEPROMClass::write error, address %d > %d or %d < 0\n", address, _size, address);
    return;
  }
  if(!_data) {
    DEBUGV("**EEPROMClass::read** without ::begin\n");
    return;
  }

Debug Messages

Nope just source code review.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions