-
Notifications
You must be signed in to change notification settings - Fork 13.3k
[Breaking] New polledtimeout #7960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks ! namespace esp8266
{
using polledTimeout = ::PolledTimeout [[ deprecated, "use PolledTimeout instead of esp8266::polledTimeout" ]];
} This fixes #7903 |
…red, fix includes
I intend this to be a strong breaking change. I don't want the legacy naming to be dragged into the future. |
@devyte The copyright header is AWOL in |
|
||
// legacy type names, deprecated (unit is milliseconds) | ||
using oneShot = TimeoutTemplate<false, YieldPolicy::DoNothing, TimePolicy::TimeMillis>; | ||
using periodic = TimeoutTemplate<true, YieldPolicy::DoNothing, TimePolicy::TimeMillis>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these kept in this breaking change commit ?
Fixes #7903
This PR restructures the polledtimeout code by separating the templates from the policies, which makes it easier for users to understand how to extend the code with new custom policies. It also separates* the generic policies that should be common to all Arduino cores from the policies that are specific to the esp8266.
The namespaces and template name have been changed to uppercase based on multiple feedback received since the frist version was implemented.
As usual, the specifics are up for discussion.