Add a PostHttpsClient example in the ESP8266HTTPClient library. #8187
Conversation
…266HTTPClient/Examples/PostHttpsClient
Alba0404
force-pushed
the
ESP8266HTTPClient/Examples/PostHttpsClient
branch
from
1408805 to
d215f57
Compare
| std::unique_ptr<BearSSL::WiFiClientSecure>client(new BearSSL::WiFiClientSecure); | ||
| client->setInsecure(); // Ignore SSL certificate | ||
| //client->setFingerprint(fingerprint); //Use SSL | ||
| HTTPClient https; |
There was a problem hiding this comment.
For coherency,
httpsis already global- why is
clientin heap andhttpsin stack ?
There was a problem hiding this comment.
- For the
httpsvar, it was a mistake, I remove the global var. - For the difference heap and stack. I don't know, it was in other examples and it works
There was a problem hiding this comment.
Stack (cons: too small or precious), Heap (cons: fragmentation), or global (cons: cannot be released), the debate is never closed.
What about using the same allocation scheme for both client and https ?
There was a problem hiding this comment.
You really want to allocate and leave allocated a WiFiClientSecure either globally or very near the beginning of setup(). This is because the client will allocate memory for itself (~17kb IIRC) but also allocate ~7kb for the SSL stack. Later in the app the heap may have enough space, but be fragmented such that you might have 30kb free but no single block of 17kb or 7kb for the stack or the SSL buffers.
…266HTTPClient/Examples/PostHttpsClient
Alba0404
force-pushed
the
ESP8266HTTPClient/Examples/PostHttpsClient
branch
from
e13bd19 to
2376fa6
Compare
|
|
||
| std::unique_ptr<BearSSL::WiFiClientSecure>client(new BearSSL::WiFiClientSecure); | ||
| client->setInsecure(); // Ignore SSL certificate | ||
| //client->setFingerprint(fingerprint); //Use SSL |
There was a problem hiding this comment.
It is prefered to use secure connections in examples.
You may leave the setInsecure() commented though.
|
pushing to v4 per still in discussion |
This PR add an example for the ESP8266HTTPClient library.
This example is a POST request using HTTPS protocol.
It was made using the PostHttpClient and GetHttpsClient examples.