Skip to content

Missing include guards on WifiProv.h #6171

Closed
@Ezekiel-DA

Description

@Ezekiel-DA

Board

ESP32 Dev Module / Any ESP32

Device Description

N/A

Hardware Configuration

N/A

Version

latest master

IDE Name

Arduino IDE

Operating System

N/A

Flash frequency

N/A

PSRAM enabled

no

Upload speed

N/A

Description

libraries/WiFiProv/src/WiFiProv.h does not appear to have include guards, causing issues if it is included multiple times from a project split into multiple source files / headers.

Other libraries seem to correctly have the usual

#ifndef <something>_H
#define <something>_H

blocks as expected, so I imagine this is a simple oversight?

This results in predictable compilation errors:

In file included from <snip>\myCustomProvCode.h:3,
                 from <snip>\myProject.ino:13:
<snip>\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.2\libraries\WiFiProv\src/WiFiProv.h:24:5: error: 'WIFI_PROV_SCHEME_SOFTAP' conflicts with a previous declaration
     WIFI_PROV_SCHEME_SOFTAP,
     ^~~~~~~~~~~~~~~~~~~~~~~

Sketch

Something like this:

Sample.ino:


#include <WifiProv.h>

#include "myCustomProvCode.h"

myCustomProvCode.h:

#include <WifiProv.h>

will trigger the compilation error above.



### Debug Message

```plain
N/A: compilation error

Other Steps to Reproduce

No response

I have checked existing issues, online documentation and the Troubleshooting Guide

  • I confirm I have checked existing issues, online documentation and Troubleshooting guide.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions