esp32-2.0.15+esp32-2.0.16 Arduino boards breaks code from running on esp32-s3 (lilygo-t-dongle)

[mrdude2478]

Board

lilygo-t-dongle-s3

Device Description

ESP32-s3 dev module

Hardware Configuration

Dongle has a winbond - W25Q32 chip + small st3775 lcd screen built in:
https://github.com/Xinyuan-LilyGO/T-Dongle-S3

Version

latest master (checkout manually)

IDE Name

Arduino IDE 1.8.19

Operating System

Windows 10

Flash frequency

QUI 80 mhz

PSRAM enabled

no

Upload speed

921600

Description

Sketch works fine, compiles and runs fine using esp32 board definitions version 2.0.14.

When the board is updated via Arduino board manager to a greater version 2.0.15+2.0.16 the sketch compiles fine and uploads but the dongle doesn't run the code anymore. I traced the fault to this file:

C:\Users\someuser\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.16\tools\sdk\esp32s3\include\soc\esp32s3\include\soc\soc.h

A new entry was added to line 122:
#define REG_SPI_BASE(i) (((i)>=2) ? (DR_REG_SPI2_BASE + (i-2) * 0x1000) : (0)) // GPSPI2 and GPSPI3

This line when commented out lets my code run fine on my dongle again using the 2.0.15+2.0.16, somehow though that line of code breaks the lilygo-t-dongle from being able to run the compiled and uploaded code.

Sketch

No issue with the sketch using the modded 2.0.16\tools\sdk\esp32s3\include\soc\esp32s3\include\soc\soc.h file with the line commented out as above.

Debug Message

No debug message is displayed.

Other Steps to Reproduce

No response

I have checked existing issues, online documentation and the Troubleshooting Guide

• I confirm I have checked existing issues, online documentation and Troubleshooting guide.

[Jason2866]

The change done in IDF to #define REG_SPI_BASE(i) (((i)>=2) ? (DR_REG_SPI2_BASE + (i-2) * 0x1000) : (0)) // GPSPI2 and GPSPI3 is wrong.
Correct is #define REG_SPI_BASE(i) (((i)==2) ? (DR_REG_SPI2_BASE) : (DR_REG_SPI0_BASE - ((i) * 0x1000))) // GPSPI2 and GPSPI3
Changed this in our IDF fork for Tasmota, which is the base for compiling the Tasmota Arduino libs.
Edit: The changes done for the other SOCs are imho wrong too. Only ESP32 looks correct.

[me-no-dev]

is this also the case with 3.0.0-rc2?

[Jason2866]

Yes, since it is wrong in IDF branch release/v5.1 https://github.com/espressif/esp-idf/blob/442a7980835731c0a720bcfd8d3ff2f7acd01835/components/soc/esp32s3/include/soc/soc.h#L37
Edit: Did a PR for the C3. Later the IDF crew implemented different (=wrong). So I gave up and fixed this in our fork the way I think it is correct and does work for us.

[mrdude2478]

@Jason2866

Thanks for your reply, I tried your modded code and unfortunately that still breaks the dongle from being able to run after being compiled and uploaded. Commenting out that line and the dongle works again.