-
Notifications
You must be signed in to change notification settings - Fork 7.6k
add dfrobot lorawan esp32s3 board #11278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello qhddz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Hi @qhddz, can you add a link to the product and more info? Thanks |
The product link has not been released yet. |
There is then no way to check if the board definition is correct. Also I see some missing stuff in the board.txt file what other boards have. Like erase flash menu, debug level, partitions selection, etc... |
remove duplicate macro definitions
cancel this pr |
add dfrobot lorawan esp32s3 board