Skip to content

Fix for confusing overload of Wire::begin #6984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix for confusing overload of Wire::begin #6984

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ca52c2
Fox for confusing overload of Wire::begin
bato3 Jul 14, 2022
789e882
Merge branch 'master' into patch-1
SuGlider Jul 14, 2022
8e18a83
Merge branch 'master' into patch-1
SuGlider Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions libraries/Wire/src/Wire.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ class TwoWire: public Stream
bool setPins(int sda, int scl);

bool begin(int sda=-1, int scl=-1, uint32_t frequency=0); // returns true, if successful init of i2c bus
inline bool begin(uint8_t sda, uint8_t scl, uint32_t frequency=0)
{
return begin(static_cast<int>(sda), static_cast<int>(scl), frequency);
}
bool begin(uint8_t slaveAddr, int sda=-1, int scl=-1, uint32_t frequency=0);
bool end();

Expand Down