Olimex ESP32-GATEWAY fixes in boards.txt and pins_arduino.h #8395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes related to board revisions selection.
|
|
P-R-O-C-H-Y
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am an Olimex employee. After some complaints from customers I reviewed the definitions to ESP32-GATEWAY and due to changes in menu definitions in boards.txt our selection between different hardware revisions didn't work. This lead to wrong config getting loaded and SD card and Ethernet not working by selecting "Olimex ESP32-GATEWAY" from the board selection.
It is not some major edit just small changes related to Olimex ESP32-GATEWAY to fit the way things are done nowadays.
I've tested this with ESP32-GATEWAY but let me know if something was not done right.