Skip to content

Added support for the Aventen S3 Sync #8585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Added support for the Aventen S3 Sync #8585

wants to merge 3 commits into from

Conversation

avencan
Copy link
Contributor

@avencan avencan commented Aug 30, 2023

Description of Change

Added the Aventen S3 Sync development board

Tests scenarios

NA

@avencan
Copy link
Contributor Author

avencan commented Aug 30, 2023

@P-R-O-C-H-Y I have created a new pull request, and deleted the previous one, I hope this works.

Thanks

@avencan
Copy link
Contributor Author

avencan commented Aug 30, 2023

I also may need you to do a thorough overview, review to know if this will work, since I've implemented it quickly, and I haven't had enough time to thoroughly check it.

E.G programming is usually via the onboard CP2102N, but I have also added some USB CDC lines, just incase the user may want to program it with the USB OTG functions, since the USB pins are exposed.

image

@P-R-O-C-H-Y P-R-O-C-H-Y self-requested a review August 30, 2023 08:00
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine :) Thanks for creating new clean PR

@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 2.0.12 milestone Aug 30, 2023
P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Aug 30, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avencan PTAL on my comments

@avencan
Copy link
Contributor Author

avencan commented Aug 30, 2023

@avencan PTAL on my comments

Hi

I've fixed the issues but now we have that issue on the big commit. Sorry about this

@P-R-O-C-H-Y
Copy link
Member

@avencan PTAL on my comments

Hi

I've fixed the issues but now we have that issue on the big commit. Sorry about this

IDK why this is happening... But we cannot merge this PR if all boards are "changed" in that commit.
Can you please open a last one, with those changes I asked you to do? Thanks

@avencan
Copy link
Contributor Author

avencan commented Aug 30, 2023

@avencan PTAL on my comments

Hi

I've fixed the issues but now we have that issue on the big commit. Sorry about this

IDK why this is happening... But we cannot merge this PR if all boards are "changed" in that commit.
Can you please open a last one, with those changes I asked you to do? Thanks

Will do ASAP thanks

@avencan avencan closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y requested changes

Assignees
No one assigned
Labels
Type: 3rd party Boards
Projects
None yet
Milestone
2.0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@avencan @P-R-O-C-H-Y