Skip to content

Add Board support for Geekble ESP32-C3 Custom Module #9260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Add Board support for Geekble ESP32-C3 Custom Module #9260

merged 3 commits into from
Feb 23, 2024

Conversation

SooDragon
Copy link
Contributor

@SooDragon SooDragon commented Feb 16, 2024

Description of Change

Add board support for Geekble ESP32C3 Module

Tests scenarios

I have tested with Arduino IDE, Version 2.3.1 and 1.8.19. Verified by compiling, uploading, testing using IO Examples and Bluetooth examples.

Related links

Copy link
Contributor

github-actions bot commented Feb 16, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add Board support for Geekble ESP32-C3 Custom Module":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix: fix conflict":
    • summary looks too short

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello SooDragon, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 6b2709c

feat: Add Board support for Geekble ESP32-C3 Custom Module
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SooDragon Small fix needed, but overall looks good :)

fix: remove globally defined variables in pins_arduino.h
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Feb 19, 2024
@me-no-dev
Copy link
Member

@SooDragon please fix the conflict :) it happens when more than one PR exists for a new board.

@VojtechBartoska VojtechBartoska added Resolution: Awaiting response Waiting for response of author and removed Status: Pending Merge Pull Request is ready to be merged labels Feb 22, 2024
@P-R-O-C-H-Y
Copy link
Member

@SooDragon Just pinging you to fix the conflicts ;)

fix: fix conflict
@SooDragon
Copy link
Contributor Author

@P-R-O-C-H-Y Thank you for ping :)

@me-no-dev me-no-dev merged commit ccacb7e into espressif:master Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants