Skip to content

Add hardware tests results #9332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2024
Merged

Add hardware tests results #9332

merged 3 commits into from
Mar 5, 2024

Conversation

lucasssvaz
Copy link
Collaborator

@lucasssvaz lucasssvaz commented Mar 4, 2024 •
edited
Loading

This PR aims add a badge to the README file to report the status of the hardware tests

@lucasssvaz lucasssvaz requested a review from P-R-O-C-H-Y March 4, 2024 14:20
@lucasssvaz lucasssvaz self-assigned this Mar 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add badge":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add filter to link":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix Libs test link":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello lucasssvaz, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 8c77d15

P-R-O-C-H-Y
P-R-O-C-H-Y reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this as we run HW tests on schedule every day at 2am?
I think we just need to improve letting us now if the tests on schedule fails.

@lucasssvaz lucasssvaz changed the title Run hardware tests on pushes Add hardware tests results Mar 5, 2024
@lucasssvaz lucasssvaz marked this pull request as draft March 5, 2024 11:03
@lucasssvaz lucasssvaz marked this pull request as ready for review March 5, 2024 11:14
@lucasssvaz lucasssvaz requested a review from P-R-O-C-H-Y March 5, 2024 11:14
@P-R-O-C-H-Y
Copy link
Member

Perfect! :)

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Mar 5, 2024
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the other link.

@me-no-dev me-no-dev merged commit a6d4252 into espressif:master Mar 5, 2024
@lucasssvaz lucasssvaz deleted the ci/hil_push branch March 5, 2024 14:18
aIecxs pushed a commit to aIecxs/arduino-esp32 that referenced this pull request Oct 24, 2024
@lucasssvaz
Add hardware tests results (espressif#9332)
3e2bbec 
* Add badge

* Add filter to link

* Fix Libs test link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@lucasssvaz lucasssvaz

Labels
Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasssvaz @P-R-O-C-H-Y @me-no-dev