Support ethdebug source locations under EOF #15994
Open
+964
−171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clonker
force-pushed
the
eof_source_locations_unoptimized
branch
2 times, most recently
from
20d6a64 to
fb559fb
Compare
clonker
force-pushed
the
eof_source_locations_unoptimized
branch
9 times, most recently
from
e6a1055 to
2a91773
Compare
clonker
force-pushed
the
eof_source_locations_unoptimized
branch
5 times, most recently
from
d82b70c to
0fd1232
Compare
clonker
force-pushed
the
eof_source_locations_unoptimized
branch
from
0fd1232 to
cf6aa71
Compare
cameel
reviewed
Apr 22, 2025
There was a problem hiding this comment.
The output here is quite long and seems to have little to do with ethdebug itself (the ethdebug JSON gets stripped). Do we need it all? What's the point?
There was a problem hiding this comment.
I think I just added it because there is the same test for non-eof. And looking at it now, I agree. There doesn't seem to be much value to keep it (or: them) around, especially with #16009 around the corner. I have removed this one.
test/cmdlineTests/standard_output_debuginfo_ethdebug_compatible_eof/input.json
Outdated
Show resolved
Hide resolved
clonker
force-pushed
the
eof_source_locations_unoptimized
branch
3 times, most recently
from
3c02df0 to
f9a0985
Compare
clonker
force-pushed
the
eof_source_locations_unoptimized
branch
from
f9a0985 to
ae80060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EthdebugSchemaheader with the relevant part of the schema mapped to structs with correspondingto_jsonmethods and validations(-1, -1))assembleEOFFixes the unoptimized part of #15978.
Fixes #15998.