-
-
Notifications
You must be signed in to change notification settings - Fork 45
Add list ops exercise #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of tiny nits
77ee6b2
to
4026492
Compare
@ErikSchierboom Thank you for reviewing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny nit
## Hints | ||
|
||
The `fold-left` and `fold-right` methods are "fold" functions, which is a concept from the functional programming world. See the Wikipedia page on folding for [general background](https://en.wikipedia.org/wiki/Fold_(higher-order_function)) and [signature/implementation hints](https://en.wikipedia.org/wiki/Fold_(higher-order_function)#Linear_folds). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should go into a separate hints.md
file (see https://github.com/exercism/elixir/blob/main/exercises/practice/strain/.docs/hints.md for an example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this? 86291ac
@fapdash You've been doing a stellar job on the emacs-lisp track. Would you be interested in becoming a maintainer? If so, please send an email to jonathan at exercism.org. He's our community manager and will sort you out. |
@ErikSchierboom Thank you! I'm interested, I'll send Jonathan an email. :) |
list-sum
: this is just to drive the point home that you can implement functions like that very easily through the primitives implemented in this exerciselist-empty-p
: I hope to bring people towards the realization that nil = empty list in Emacs Lisp, checking if thecar
andcdr
of a list are nil will not work.Regarding
list-empty-p
we had this discussion on slack: https://app.slack.com/client/TAN6QMALR/CAQP7JL3T/thread/CAQP7JL3T-1665705236.652139I think there should eventually b a learning / concept exercise that explains
(equal nil '())
but for now it's better to have it in this exercise than not have it at all.