Added roman-numerals exercise. #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@canweriotnow do you have a moment to review this one? |
|
The example implementation converts 5000 to "MMMMM" which should be invalid. Otherwise it seems to check out. |
|
Do we need to add a case to https://github.com/exercism/x-common/blob/master/roman-numerals.json? |
| ;;; roman-numerals.el --- roman-numerals Exercise (exercism) | ||
|
|
||
| ;;; Commentary: | ||
|
|
There was a problem hiding this comment.
Personally, I prefer when over single branch if.
|
I think it's good for now, capping the use case at decoding at 3k works, tests pass. Merging. |
wobh
reviewed
Oct 5, 2016
| @@ -20,6 +20,8 @@ | |||
| ("IV" . 4) | |||
| ("I" . 1))) | |||
| (roman nil)) | |||
| (if (> value 3000) | |||
There was a problem hiding this comment.
Why 3000? You can make Roman numerals up through 4999.
BNAndras
added a commit
to BNAndras/exercism-emacs-lisp
that referenced
this pull request
Apr 22, 2024
BNAndras
added a commit
that referenced
this pull request
Apr 24, 2024
* Add author from #39 * Sync tests and update stub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if there are any problems!