Implemented all "Phone Number" problems from the canonical test data. (#465) #472
Conversation
- Revised the following tests using the canonical test data.
cleans-number-test
cleans-numbers-with-dots-test
valid-when-11-digits-and-first-is-1-test
- Revised the following tests specific for "Phone Number" to conform
the requirements for phone numbers.
area-code-test
pprint-test
pprint-full-us-phone-number-test
…#465) - The track-specific three problems are still included, but their solutions have been corrected.
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
The difficulty of "phone number" is reverted back to 2.
borderite
force-pushed
the
phone-number-tests-fix
branch
2 times, most recently
from
ad90fc2 to
1dc6672
Compare
- The tests expecting errors now check custom errors instead of error messages. - The example test has been modified so that it passes the modified tests.
There was a problem hiding this comment.
lgtm :)
@borderite Feel free to add yourself to the list of contributors for this exercise, you've done significant work on this exercise:
emacs-lisp/exercises/practice/phone-number/.meta/config.json
Lines 5 to 7 in 906e325
You'll receive points on Exercism for the PR without it, but people included in the list get an extra shoutout below the exercise introduction:
Popup on click:
|
@fapdash Thanks for your suggestion. I've added my name to the contributor list. |
I have revised the phone-number-test.el to include all problems from the canonical test data and correct the three track-specific problems.