Skip to content

Typescript 4.3.5 #11022

Closed
Closed
@icecream17

Description

@icecream17

Describe the bug

Typescript just released a new version: 4.3.2 4.3.5

Did you try recovering your dependencies?

N/A

Which terms did you search for in User Guide?

None (was just released June 30th)

Environment

(gitpod since I only have access to an online terminal)

Environment Info:

  current version of create-react-app: 4.0.3
  running from /home/gitpod/.nvm/versions/node/v14.17.0/lib/node_modules/create-react-app

  System:
    OS: Linux 5.4 Ubuntu 20.04.2 LTS (Focal Fossa)
    CPU: (16) x64 Intel(R) Xeon(R) CPU
  Binaries:
    Node: 14.17.0 - ~/.nvm/versions/node/v14.17.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.17.0/bin/yarn
    npm: 7.14.0 - ~/.nvm/versions/node/v14.17.0/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
  npmPackages:
    react: ^17.0.2 => 17.0.2 
    react-dom: ^17.0.2 => 17.0.2 
    react-scripts: 4.0.3 => 4.0.3 
  npmGlobalPackages:
    create-react-app: 4.0.3

Steps to reproduce

(Write your steps here:)

  1. Create a new typescript app
  2. Use the override keyword (see typescript's release notes or the repro below)
  3. Doesn't compile

Expected behavior

Now that I know the new version was just released, this is normal

Actual behavior

Discovered with:
https://github.com/icecream17/solver/runs/2686100874?check_suite_focus=true

Reproducible demo

I don't feel like making a demo so here's more detailed instructions

npx create-react-app example
cd example
npm install --save-prod [email protected]
// Then change App.tsx
class A {
  b(){}
}

class B extends A {
  override b () {}
}
npm test

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions