-
-
Notifications
You must be signed in to change notification settings - Fork 27k
chore: migrate to @babel/eslint-parser #10761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fffa7f1
chore: migrate to @babel/eslint-parser
JLHwung aa05b67
add more plugins enabled by babel-eslint 10
JLHwung bb5e14b
update readme
JLHwung f4dc788
provide @babel/eslint-parser for react-error-overlay
JLHwung 41050b4
chore: add other proposals enabled by babel-eslint
JLHwung 3d18c0a
chore: yarn compile:lockfile
JLHwung d652b81
Merge branch 'master' of github.com:facebook/create-react-app into sw…
mrmckeb 663cb6b
revert changes to yarn.lock.cached
mrmckeb 864f3ce
Use babel-preset-react-app
mrmckeb 1be242e
Update README
mrmckeb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -194,7 +194,9 @@ function build(previousFileSizes) { | |
messages.warnings.length | ||
) { | ||
// Ignore sourcemap warnings in CI builds. See #8227 for more info. | ||
const filteredWarnings = messages.warnings.filter(w => !/Failed to parse source map/.test(w)); | ||
const filteredWarnings = messages.warnings.filter( | ||
w => !/Failed to parse source map/.test(w) | ||
); | ||
Comment on lines
+197
to
+199
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems to have come from Prettier, we can leave it in. |
||
if (filteredWarnings.length) { | ||
console.log( | ||
chalk.yellow( | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.