-
-
Notifications
You must be signed in to change notification settings - Fork 27k
Fix e2e docker tests fails on lerna publish and other test fixes #9811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix e2e docker tests fails on lerna publish and other test fixes #9811
Conversation
Hi @raix! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
I just saw new errors on master that I don't have locally yet... I'll close this pull-request until master passes tests, to make sure I don't contribute to more issues in the test setup. |
@iansu This pull-request should fix e2e:docker and puppeteer locally (I guess also add support for github/vs code "development in docker") Would be nice to have all tests passing and block merges to master if they are not. (eg. when making this change and updating the project to webpack 5 I could only see my app working, but not if I was breaking any tests) |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This pull-request attempts to fix the e2e:docker test suite locally
X11lib
yarn e2e:docker
to start running if git has untracked changes - this would cause the tests to fail at some pointNot in this pull-request is fixing test issues:
ModuleScopePlugin
is triggered on local package likewebpackHotDevClient
in smoke tests, will be fixed in Fix refreshOverlayInterop module scope error #9805e2e-installs.sh
last testTest when PnP is enabled
is broken (at least locally)