Skip to content

Missing PEP517 metadata #1419

Open
Open
@VDuchauffour

Description

@VDuchauffour

🚀 Feature - Adding PEP517 metadata

The PEP517 introduces a possibility to build packages isolated from the runtime environment. Currently no metadata for the build are provided, so it seems impossible to install Pytorch3D with a tool like poetry or pdm.
For instance, trying to install Pytorch3D with the command poetry add git+https://github.com/facebookresearch/pytorch3d.git gives this error:

Command ['/tmp/tmp3zxip3u8/.venv/bin/python', 'setup.py', 'egg_info'] errored with the following return code 1, and output: 
Traceback (most recent call last):
  File "setup.py", line 15, in <module>
    import torch
ModuleNotFoundError: No module named 'torch'

Like for Torch (here), adding a pyproject.toml file with the following content could fix the issue. It from this issue.

[build-system]
requires = ["setuptools", "wheel", "torch"]
build-backend = "setuptools.build_meta:__legacy__"

Would you accept to adding this ?
Thank you

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions