Skip to content

👷 Add retries to Smokeshow #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

svlandeg
Copy link
Member

@@ -27,7 +27,6 @@ jobs:
strategy:
matrix:
python-version:
- "3.7"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to pass the CI for now. In fact, I want to fix the test suite so that it runs again for Python 3.7 (see #1290 and #1301) but I'm running into issues with Smokeshow apparently hanging, and I want to see whether these retries will fix that. Once this is merged, I'll add support for 3.7 back into the test suite in #1301.

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks! 🚀

@tiangolo tiangolo merged commit cd05bfe into fastapi:main Feb 20, 2025
24 checks passed
@svlandeg svlandeg deleted the feat/smokeshow branch February 20, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants