PHP Intellisense, huge memory leak when building cache

[evoliatis]

We use vscode and php intellisense with Laravel project and we have a huge memory leak (16 Go in 5 minutes) with this file : vendor/symfony/http-kernel/DependencyInjection/RegistrerControllerArgumentLocatorsPass.php during building cache.

If I renamed this file .OLD , all cache will be built without any problem. If i renamed it .php after the cache is build, all is OK.

My version :

Version 1.19.0
Commit 816be6780ca8bd0ab80314e11478c48c70d09383
Date 2017-12-14T09:56:48.842Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64
PHP Intellisense 2.2.2
Laravel Project

[jakewisse]

I'm experiencing this issue as well. In VSCode, the language server's output hangs when parsing Rule.php from sabberworm/PHP-CSS-Parser. Quit and reopened the same project (WordPress env. with a plugin installed that has this lib. as a dependency) a few times attempting to debug the issue, and was then prompted by a Mac OS dialog asking me to close running apps due to excessive memory usage. Activity Monitor showed a few php processes using tens of GB of memory.

Pasted the diff of Rule.php into a gist, showing recent changes introduced during an upgrade of a dependent WP plugin. Not sure if this issue is due to these changes, or changes in php-language-server which I received during an upgrade, but I figure the more info the better.

[felixfbecker]

felixfbecker/vscode-php-intellisense#192

[phil-nelson]

when parsing Rule.php

Yeah so this line (109) is the cause:

foreach ($mValue->getListComponents() as $mValue) {

The recent foreach handling has a bug where if the foreach collection variable is the same as the value (in this case $mValue) then it gets stuck in a loop trying to resolve $mValue. PR is up with a potential fix.

[jakewisse]

Thanks for the quick turnaround on that fix, @felixfbecker and @phil-nelson! 🙇