Skip to content

refactor: follow up PR with updates based on feedback #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 8, 2025

Conversation

russellwheatley
Copy link
Member

Contains the following:

  1. Refactored the protocol and class names for providers so they contain AuthUI. Example - FacebookProviderSwift has changed to FacebookProviderAuthUI.
  2. Updated Button Views with label argument rather than using anonymous closure.
  3. Implemented ContentView for SwiftUI example app.
  4. Created Previews for almost all Views, needed a FirebaseApp configured for a lot as we initialise FirebaseAuth in AuthService. I didn't create a preview for AuthPicker as it will be refactored soon with the implementation of View modifiers to choose authentication methods available. I will add it once that has been refactored.

Let me know what you think, @peterfriese. Just as an aside, the UI Views don't look great at the moment as we're awaiting UI design.

Copy link
Contributor

@peterfriese peterfriese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few more comments

@russellwheatley russellwheatley merged commit 027572b into main May 8, 2025
15 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants