Firebase ML Kit Publish and Unpublish Implementation #345

ifielker · 2019-09-11T18:24:53Z

Firebase ML Kit Publish and Unpublish Implementation

hiranya911

A few renaming suggestions.

hiranya911 · 2019-09-11T20:10:46Z

firebase_admin/mlkit.py

@@ -659,6 +686,17 @@ def update_model(self, model, update_mask=None):
        except requests.exceptions.RequestException as error:
            raise _utils.handle_platform_error_from_requests(error)

+    def publish_model(self, model_id, publish):


May be call this set_published()

hiranya911 · 2019-09-11T20:14:08Z

tests/test_mlkit.py

+    (mlkit.publish_model, True),
+    (mlkit.unpublish_model, False)
+]
+PUBLISH_AND_UNPUBLISH_ARGS = [mlkit.publish_model, mlkit.unpublish_model]


PUBLISH_AND_UNPUBLISH_FUNCS = [item[0] for item in PUBLISH_AND_UNPUBLISH_FUNCS_WITH_ARGS]

hiranya911 · 2019-09-11T20:14:43Z

tests/test_mlkit.py

@@ -277,7 +277,11 @@
 PAGE_SIZE_VALUE_ERROR_MSG = 'Page size must be a positive integer between ' \
                            '1 and {0}'.format(mlkit._MAX_PAGE_SIZE)
 INVALID_STRING_OR_NONE_ARGS = [0, -1, 4.2, 0x10, False, list(), dict()]
-
+PUBLISH_AND_UNPUBLISH_VALUE_ARGS = [


PUBLISH_AND_UNPUBLISH_FUNCS_WITH_ARGS

pylint doesn't like more than 30 characters. Changed to PUBLISH_UNPUBLISH_WITH_ARGS

hiranya911 · 2019-09-11T20:17:15Z

tests/test_mlkit.py

@@ -277,7 +277,11 @@
 PAGE_SIZE_VALUE_ERROR_MSG = 'Page size must be a positive integer between ' \
                            '1 and {0}'.format(mlkit._MAX_PAGE_SIZE)
 INVALID_STRING_OR_NONE_ARGS = [0, -1, 4.2, 0x10, False, list(), dict()]
-
+PUBLISH_AND_UNPUBLISH_VALUE_ARGS = [


Instead of putting these in the module namespace, you might want to put them in the TestPublishUnpublish class.

Same goes for most other constants in this file. But you can do that in a future PR if you want.

Done for these 2. I can move the rest in a future PR

hiranya911

LGTM

* Introduced the exceptions module (#296) * Added the exceptions module * Cleaned up the error handling logic; Added tests * Updated docs; Fixed some typos * Migrating FCM Send APIs to the New Exceptions (#297) * Migrated FCM send APIs to the new error handling regime * Moved error parsing logic to _utils * Refactored OP error handling code * Fixing a broken test * Added utils for handling googleapiclient errors * Added tests for new error handling logic * Updated public API docs * Fixing test for python3 * Cleaning up the error code lookup code * Cleaning up the error parsing APIs * Cleaned up error parsing logic; Updated docs * Migrated remaining messaging APIs to new error types (#298) * Migrated FCM send APIs to the new error handling regime * Moved error parsing logic to _utils * Refactored OP error handling code * Fixing a broken test * Added utils for handling googleapiclient errors * Added tests for new error handling logic * Updated public API docs * Fixing test for python3 * Cleaning up the error code lookup code * Cleaning up the error parsing APIs * Cleaned up error parsing logic; Updated docs * Migrated the FCM IID APIs to the new error types * Introducing TokenSignError to represent custom token creation errors (#302) * Migrated FCM send APIs to the new error handling regime * Moved error parsing logic to _utils * Refactored OP error handling code * Fixing a broken test * Added utils for handling googleapiclient errors * Added tests for new error handling logic * Updated public API docs * Fixing test for python3 * Cleaning up the error code lookup code * Cleaning up the error parsing APIs * Cleaned up error parsing logic; Updated docs * Migrated the FCM IID APIs to the new error types * Migrated custom token API to new error types * Raising FirebaseError from create_session_cookie() API (#306) * Migrated FCM send APIs to the new error handling regime * Moved error parsing logic to _utils * Refactored OP error handling code * Fixing a broken test * Added utils for handling googleapiclient errors * Added tests for new error handling logic * Updated public API docs * Fixing test for python3 * Cleaning up the error code lookup code * Cleaning up the error parsing APIs * Cleaned up error parsing logic; Updated docs * Migrated the FCM IID APIs to the new error types * Migrated custom token API to new error types * Migrated create cookie API to new error types * Improved error message computation * Refactored the shared error handling code * Fixing lint errors * Renamed variable for clarity * Introducing UserNotFoundError type (#309) * Added UserNotFoundError type * Fixed some lint errors * Some formatting updates * Updated docs and tests * New error handling support in create/update/delete user APIs (#311) * New error handling support in create/update/delete user APIs * Fixing some lint errors * Error handling improvements in email action link APIs (#312) * New error handling support in create/update/delete user APIs * Fixing some lint errors * Error handling update in email action link APIs * Project management API migrated to new error types (#314) * Error handling updated for remaining user_mgt APIs (#315) * Error handling updated for remaining user_mgt APIs * Removed unused constants * Migrated token verification APIs to new exception types (#317) * Migrated token verification APIs to new error types * Removed old AuthError type * Added new exception types for revoked tokens * Migrated the db module to the new exception types (#318) * Migrating db module to new exception types * Error handling for transactions * Updated integration tests * Restoring the old txn abort behavior * Updated error type in snippet * Added comment * Adding a few overlooked error types (#319) * Adding some missing error types * Updated documentation * Removing the ability to delete user properties by passing None (#320) * Adding beginning of _MLKitService (#323) * Adding beginning of _MLKitService * Added License and Docstring * Firebase ML Kit Get Model API implementation (#326) * added GetModel * Added tests for get_model * Firebase ML Kit Delete Model API implementation (#327) * implement delete model * Firebase ML Kit List Models API implementation (#331) * implemented list models plus tests * Implementation of Model, ModelFormat, TFLiteModelSource and subclasses (#335) * Implementation of Model, ModelFormat, ModelSource and subclasses * Firebase ML Kit Create Model API implementation (#337) * create model plus long running operation handling * Model.wait_for_unlocked * Firebase ML Kit Update Model API implementation (#343) * Firebase ML Kit Create Model API implementation * Firebase ML Kit Publish and Unpublish Implementation (#345) * Firebase ML Kit Publish and Unpublish Implementation * Firebase ML Kit TFLiteGCSModelSource.from_tflite_model implementation and conversion helpers (#346) * Firebase ML Kit TFLiteGCSModelSource.from_tflite_model implementation * support for tensorflow lite conversion helpers (version 1.x) * Quick pass at filling in missing docstrings (#367) * Quick pass at filling in missing docstrings * More punctuation * Modify Operation Handling to not require a name for Done Operations (#371) * Firebase ML Kit Modify Operation Handling to not require a name for Done Operations * Adding support for TensorFlow 2.x * rename from mlkit to ml (#373) * Adding File naming capability to from_saved_model and from_keras_model. (#375) adding File naming capability for ModelSource * Firebase ML Modify Operation Handling Code to match rpc codes not html codes (#390) * Firebase ML Modify Operation Handling Code to match actual codes * apply database fix too * Mlkit fix date handling2 (#391) * Fix create/update date handling * Skip unrelated failing tests (until sync) * Firebase Ml Fix upload file naming (#392) * Fix File Naming * Integration tests for Firebase ML (#394) * Integration tests for Firebase ML * Fixing lint errors for Py3 (#401) * Fixing lint errors for Py3 * Removed dependency on six * Fixing a couple of merge errors * Modifying operation handling to support backend changes (#423) * modifying operation handling to support backend changes * Firebase ML Changing service endpoint (#421) * Mlkit add headers (#445) * add Headers * fixed test (#448) * Adding tensorflow and keras so we don't skip tests (#449) * Adding tensorflow and keras so we don't skip tests * Add additional instructions for integration tests for ml Co-authored-by: Hiranya Jayathilaka <[email protected]> Co-authored-by: Kevin Cheung <[email protected]>

ifielker added 3 commits September 11, 2019 14:23

Firebase ML Kit Publish and Unpublish Implementation

535b66a

fix tests

1f7ba94

fixed lint

4864c15

ifielker requested a review from hiranya911 September 11, 2019 18:54

ifielker assigned hiranya911 Sep 11, 2019

hiranya911 suggested changes Sep 11, 2019

View reviewed changes

hiranya911 assigned ifielker and unassigned hiranya911 Sep 11, 2019

review comments

b274bc7

ifielker assigned hiranya911 Sep 11, 2019

hiranya911 approved these changes Sep 11, 2019

View reviewed changes

hiranya911 removed their assignment Sep 11, 2019

ifielker merged commit 0344172 into mlkit Sep 11, 2019

ifielker deleted the mlkit-8 branch September 11, 2019 23:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Firebase ML Kit Publish and Unpublish Implementation #345

Firebase ML Kit Publish and Unpublish Implementation #345

Uh oh!

ifielker commented Sep 11, 2019

Uh oh!

hiranya911 left a comment

Uh oh!

hiranya911 Sep 11, 2019

Uh oh!

ifielker Sep 11, 2019

Uh oh!

hiranya911 Sep 11, 2019

Uh oh!

ifielker Sep 11, 2019 •

edited

Loading

Uh oh!

hiranya911 Sep 11, 2019

Uh oh!

ifielker Sep 11, 2019

Uh oh!

hiranya911 Sep 11, 2019

Uh oh!

ifielker Sep 11, 2019

Uh oh!

hiranya911 left a comment

Uh oh!

Uh oh!

Firebase ML Kit Publish and Unpublish Implementation #345

Firebase ML Kit Publish and Unpublish Implementation #345

Uh oh!

Conversation

ifielker commented Sep 11, 2019

Uh oh!

hiranya911 left a comment

Choose a reason for hiding this comment

Uh oh!

hiranya911 Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

ifielker Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

hiranya911 Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

ifielker Sep 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hiranya911 Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

ifielker Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

hiranya911 Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

ifielker Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

hiranya911 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ifielker Sep 11, 2019 •

edited

Loading