Skip to content

Support custom tabs in more browsers #6705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 24, 2025
Merged

Support custom tabs in more browsers #6705

merged 5 commits into from
Feb 24, 2025

Conversation

Fry-kun
Copy link
Contributor

@Fry-kun Fry-kun commented Feb 14, 2025

fixes #6692

@Fry-kun Fry-kun marked this pull request as draft February 14, 2025 23:22
@Fry-kun Fry-kun marked this pull request as ready for review February 14, 2025 23:29
Copy link
Contributor

@lfkellogg lfkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add this to AndroidManifest.xml (under <manifest>):

    <queries>
        <intent>
            <action android:name="android.support.customtabs.action.CustomTabsService" />
        </intent>
    </queries>

Source: https://developer.android.com/reference/androidx/browser/customtabs/CustomTabsClient#getPackageName(android.content.Context,java.util.List%3Cjava.lang.String%3E,boolean)

@lfkellogg
Copy link
Contributor

BTW I tested this locally and confirmed it works on older (API level 29) and newer (API level 34) devices.

@Fry-kun Fry-kun requested a review from lfkellogg February 24, 2025 18:57
@lfkellogg lfkellogg merged commit a2244f9 into firebase:main Feb 24, 2025
24 checks passed
@lfkellogg lfkellogg mentioned this pull request Feb 24, 2025
lfkellogg added a commit that referenced this pull request Feb 24, 2025
@Fry-kun Fry-kun deleted the custom-tabs branch February 24, 2025 20:49
VinayGuthal pushed a commit that referenced this pull request Feb 24, 2025
@MarNwk
Copy link

MarNwk commented Mar 17, 2025

Hey there! I was wondering if you have an estimate for when the fix will be released. Any idea on the timeline for this?

@lfkellogg
Copy link
Contributor

Hey there! I was wondering if you have an estimate for when the fix will be released. Any idea on the timeline for this?

Hi @MarNwk - the fix is currently scheduled to go out in the next release, targeting this week or next week.

@MarNwk
Copy link

MarNwk commented Mar 19, 2025

Hey @lfkellogg, great 🥳 ! Thanks for the quick update 🙇

@firebase firebase locked and limited conversation to collaborators Mar 27, 2025
tejasd pushed a commit that referenced this pull request Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom tab handling not taking packages other than Chrome into account
4 participants