Skip to content

Remove unnecessary steps in CI Testing for vertex #6743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Mar 6, 2025

Additionally, make the update_responses.sh more verbose to ease debugging

Additionally, make the update_responses.sh more verbose to ease debugging
Copy link
Contributor

github-actions bot commented Mar 6, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

github-actions bot commented Mar 6, 2025

Test Results

 1 088 files  + 54   1 088 suites  +54   34m 59s ⏱️ +32s
 5 893 tests ±  0   5 870 ✅  -   1  22 💤 ±0  1 ❌ +1 
12 765 runs  +916  12 718 ✅ +913  46 💤 +2  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 441c9d9. ± Comparison against base commit e12597e.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (e12597e) to 75.72% (f63b87b) by ?.

    68 individual files with coverage change

    FilenameBase (e12597e)Merge (f63b87b)Diff
    AabUpdater.java?98.36%?
    AabUpdater_Factory.java?0.00%?
    ApkInstaller.java?100.00%?
    ApkInstaller_Factory.java?0.00%?
    ApkUpdater.java?92.63%?
    ApkUpdater_Factory.java?0.00%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppDistroComponent.java?0.00%?
    AppDistroComponent_MainModule_BindContentResolverFactory.java?0.00%?
    AppIconSource.java?84.62%?
    AppIconSource_Factory.java?100.00%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?71.58%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    DaggerAppDistroComponent.java?80.56%?
    DevModeDetector.java?9.09%?
    DevModeDetector_Factory.java?100.00%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?3.39%?
    FeedbackActivity_MembersInjector.java?0.00%?
    FeedbackSender.java?84.48%?
    FeedbackSender_Factory.java?0.00%?
    FeedbackTrigger.java?61.54%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?89.89%?
    FirebaseAppDistributionImpl_Factory.java?0.00%?
    FirebaseAppDistributionLifecycleNotifier.java?91.49%?
    FirebaseAppDistributionLifecycleNotifier_Factory.java?0.00%?
    FirebaseAppDistributionNotificationsManager.java?88.89%?
    FirebaseAppDistributionNotificationsManager_Factory.java?0.00%?
    FirebaseAppDistributionRegistrar.java?95.83%?
    FirebaseAppDistributionTesterApiClient.java?88.78%?
    FirebaseAppDistributionTesterApiClient_Factory.java?0.00%?
    HttpsUrlConnectionFactory.java?50.00%?
    HttpsUrlConnectionFactory_Factory.java?100.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.67%?
    LogWrapper.java?86.67%?
    NewReleaseFetcher.java?86.67%?
    NewReleaseFetcher_Factory.java?0.00%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?91.78%?
    ReleaseIdentifier_Factory.java?0.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?36.17%?
    ScreenshotTaker_Factory.java?0.00%?
    SequentialReference.java?100.00%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?100.00%?
    SignInStorage_Factory.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity_MembersInjector.java?0.00%?
    TaskCache.java?100.00%?
    TaskCompletionSourceCache.java?72.41%?
    TaskUtils.java?77.50%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?90.09%?
    TesterApiHttpClient_Factory.java?0.00%?
    TesterSignInManager.java?89.41%?
    TesterSignInManager_Factory.java?0.00%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskCache.java?91.30%?
    UpdateTaskImpl.java?76.32%?

  • firebase-database

    Overall coverage changed from 50.16% (e12597e) to 50.21% (f63b87b) by +0.04%.

    FilenameBase (e12597e)Merge (f63b87b)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
  • firebase-messaging

    Overall coverage changed from 84.15% (e12597e) to 84.12% (f63b87b) by -0.04%.

    FilenameBase (e12597e)Merge (f63b87b)Diff
    FirebaseMessaging.java76.00%75.60%-0.40%
  • firebase-storage

    Overall coverage changed from 84.33% (e12597e) to 83.96% (f63b87b) by -0.37%.

    FilenameBase (e12597e)Merge (f63b87b)Diff
    StorageException.java69.09%65.45%-3.64%
    StorageTask.java83.99%83.38%-0.60%
    UploadTask.java83.17%81.52%-1.65%
  • firebase-firestore

    FilenameBase (e12597e)Merge (f63b87b)Diff
    PatchMutation.java100.00%98.39%-1.61%
    SetMutation.java94.44%97.22%+2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/e4czuXOgRY.html

@rlazo rlazo merged commit 4128d9a into main Mar 7, 2025
260 of 263 checks passed
@rlazo rlazo deleted the rl.ci.vertex.update branch March 7, 2025 00:17
tejasd pushed a commit that referenced this pull request Apr 1, 2025
Additionally, make the update_responses.sh more verbose to ease debugging
@firebase firebase locked and limited conversation to collaborators Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants