Skip to content

[RC] Remove package declaration from testapp manifest #6875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Apr 15, 2025

This is a leftover from a previous migration that moved the namespace/package declarations from the AndroidManifest.xml files to the gradle build files.

This is a leftover from a previous migration that moved the
namespace/package declarations from the `AndroidManifest.xml` files to
the gradle build files.
Copy link
Contributor

github-actions bot commented Apr 15, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@rlazo rlazo requested review from davidmotson and daymxn April 15, 2025 15:20
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2025

Coverage Report 1

Affected Products

No changes between base commit (24b9dad) and merge commit (af8ae75).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TdJ9EHXrmS.html

Copy link
Contributor

github-actions bot commented Apr 15, 2025

Test Results

0 files   -  1 017  0 suites   - 1 017   0s ⏱️ - 34m 17s
0 tests  -  5 874  0 ✅  -  5 851  0 💤  - 22  0 ❌  - 1 
0 runs   - 11 623  0 ✅  - 11 578  0 💤  - 44  0 ❌  - 1 

Results for commit 638630e. ± Comparison against base commit 24b9dad.

♻️ This comment has been updated with latest results.

@rlazo rlazo requested a review from VinayGuthal April 15, 2025 15:45
@google-oss-bot
Copy link
Contributor

@rlazo rlazo merged commit 5aff679 into main Apr 15, 2025
28 of 30 checks passed
@rlazo rlazo deleted the rl.rc.bandwagon.manifest branch April 15, 2025 15:51
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-rc

    DeviceStatisticsDistributions
    oriole-32
    Percentile24b9dadaf8ae75DiffSignificant (?)
    p10178 ±282 μs180 ±195 μs+1.23 μs (+0.7%)NO
    p25186 ±288 μs194 ±207 μs+8.56 μs (+4.6%)NO
    p50201 ±302 μs226 ±231 μs+25.5 μs (+12.7%)NO
    p75223 ±322 μs272 ±262 μs+49.4 μs (+22.2%)NO
    p90279 ±345 μs332 ±283 μs+52.9 μs (+18.9%)NO

    20 test runs in comparison
    CommitTest Runs
    24b9dad
    • 2025-04-15_15:29:06.555100_RmZZ
    • 2025-04-15_15:29:06.555138_nrER
    • 2025-04-15_15:29:06.555148_mEtk
    • 2025-04-15_15:29:06.555156_Onyj
    • 2025-04-15_15:29:06.555163_fKdF
    • 2025-04-15_15:29:06.555170_TzkX
    • 2025-04-15_15:29:06.555177_OBHK
    • 2025-04-15_15:29:06.555183_XyoY
    • 2025-04-15_15:29:06.555189_vzmN
    • 2025-04-15_15:29:06.555196_KfOF
    af8ae75
    • 2025-04-15_15:50:46.639004_UhLf
    • 2025-04-15_15:50:46.639044_pKIu
    • 2025-04-15_15:50:46.639054_HObr
    • 2025-04-15_15:50:46.639062_MPxN
    • 2025-04-15_15:50:46.639069_IQok
    • 2025-04-15_15:50:46.639077_PIyD
    • 2025-04-15_15:50:46.639091_oxvc
    • 2025-04-15_15:50:46.639098_BZlw
    • 2025-04-15_15:50:46.639105_DLsE
    • 2025-04-15_15:50:46.639111_TLPV
    redfin-30
    Percentile24b9dadaf8ae75DiffSignificant (?)
    p10608 ±600 μs393 ±474 μs-215 μs (-35.4%)NO
    p25713 ±704 μs460 ±573 μs-253 μs (-35.5%)NO
    p50897 ±841 μs582 ±682 μs-316 μs (-35.2%)NO
    p751.20 ±1 ms755 ±820 μs-442 μs (-36.9%)NO
    p901.56 ±1 ms1.03 ±1 ms-528 μs (-33.8%)NO

    20 test runs in comparison
    CommitTest Runs
    24b9dad
    • 2025-04-15_15:29:06.555100_RmZZ
    • 2025-04-15_15:29:06.555138_nrER
    • 2025-04-15_15:29:06.555148_mEtk
    • 2025-04-15_15:29:06.555156_Onyj
    • 2025-04-15_15:29:06.555163_fKdF
    • 2025-04-15_15:29:06.555170_TzkX
    • 2025-04-15_15:29:06.555177_OBHK
    • 2025-04-15_15:29:06.555183_XyoY
    • 2025-04-15_15:29:06.555189_vzmN
    • 2025-04-15_15:29:06.555196_KfOF
    af8ae75
    • 2025-04-15_15:50:46.639004_UhLf
    • 2025-04-15_15:50:46.639044_pKIu
    • 2025-04-15_15:50:46.639054_HObr
    • 2025-04-15_15:50:46.639062_MPxN
    • 2025-04-15_15:50:46.639069_IQok
    • 2025-04-15_15:50:46.639077_PIyD
    • 2025-04-15_15:50:46.639091_oxvc
    • 2025-04-15_15:50:46.639098_BZlw
    • 2025-04-15_15:50:46.639105_DLsE
    • 2025-04-15_15:50:46.639111_TLPV
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile24b9dadaf8ae75DiffSignificant (?)
    p10199 ±3 ms203 ±5 ms+4.48 ms (+2.3%)NO
    p25204 ±3 ms209 ±5 ms+4.49 ms (+2.2%)NO
    p50211 ±3 ms216 ±5 ms+4.93 ms (+2.3%)NO
    p75219 ±3 ms224 ±6 ms+5.69 ms (+2.6%)NO
    p90226 ±4 ms235 ±8 ms+8.37 ms (+3.7%)NO

    20 test runs in comparison
    CommitTest Runs
    24b9dad
    • 2025-04-15_15:29:06.555100_RmZZ
    • 2025-04-15_15:29:06.555138_nrER
    • 2025-04-15_15:29:06.555148_mEtk
    • 2025-04-15_15:29:06.555156_Onyj
    • 2025-04-15_15:29:06.555163_fKdF
    • 2025-04-15_15:29:06.555170_TzkX
    • 2025-04-15_15:29:06.555177_OBHK
    • 2025-04-15_15:29:06.555183_XyoY
    • 2025-04-15_15:29:06.555189_vzmN
    • 2025-04-15_15:29:06.555196_KfOF
    af8ae75
    • 2025-04-15_15:50:46.639004_UhLf
    • 2025-04-15_15:50:46.639044_pKIu
    • 2025-04-15_15:50:46.639054_HObr
    • 2025-04-15_15:50:46.639062_MPxN
    • 2025-04-15_15:50:46.639069_IQok
    • 2025-04-15_15:50:46.639077_PIyD
    • 2025-04-15_15:50:46.639091_oxvc
    • 2025-04-15_15:50:46.639098_BZlw
    • 2025-04-15_15:50:46.639105_DLsE
    • 2025-04-15_15:50:46.639111_TLPV
    redfin-30
    Percentile24b9dadaf8ae75DiffSignificant (?)
    p10227 ±4 ms248 ±3 ms+20.6 ms (+9.1%)MAYBE
    p25234 ±4 ms255 ±3 ms+21.3 ms (+9.1%)YES
    p50242 ±5 ms263 ±3 ms+21.1 ms (+8.7%)MAYBE
    p75250 ±5 ms272 ±4 ms+22.2 ms (+8.9%)MAYBE
    p90260 ±6 ms288 ±8 ms+27.7 ms (+10.6%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    24b9dad
    • 2025-04-15_15:29:06.555100_RmZZ
    • 2025-04-15_15:29:06.555138_nrER
    • 2025-04-15_15:29:06.555148_mEtk
    • 2025-04-15_15:29:06.555156_Onyj
    • 2025-04-15_15:29:06.555163_fKdF
    • 2025-04-15_15:29:06.555170_TzkX
    • 2025-04-15_15:29:06.555177_OBHK
    • 2025-04-15_15:29:06.555183_XyoY
    • 2025-04-15_15:29:06.555189_vzmN
    • 2025-04-15_15:29:06.555196_KfOF
    af8ae75
    • 2025-04-15_15:50:46.639004_UhLf
    • 2025-04-15_15:50:46.639044_pKIu
    • 2025-04-15_15:50:46.639054_HObr
    • 2025-04-15_15:50:46.639062_MPxN
    • 2025-04-15_15:50:46.639069_IQok
    • 2025-04-15_15:50:46.639077_PIyD
    • 2025-04-15_15:50:46.639091_oxvc
    • 2025-04-15_15:50:46.639098_BZlw
    • 2025-04-15_15:50:46.639105_DLsE
    • 2025-04-15_15:50:46.639111_TLPV

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/wCgtCU7WLh/index.html

@firebase firebase locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants