Skip to content

[Firebase AI] Fix goldenDevAPIStreamingFile util #6923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

andrewheard
Copy link
Collaborator

The goldenDevAPIStreamingFile was returning golden files for Vertex AI. Switching this to Google AI should result in the prompt blocked for safety test failing since the Google AI version of streaming-failure-prompt-blocked-safety.txt does not contain a blocked prompt response.

Copy link
Contributor

github-actions bot commented Apr 29, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

Test Results

 29 files   -  1 008   29 suites   - 1 008   21s ⏱️ - 33m 57s
184 tests  -  5 788  181 ✅  -  5 768  0 💤  - 22  3 ❌ +2 
270 runs   - 11 413  267 ✅  - 11 371  0 💤  - 44  3 ❌ +2 

For more details on these failures, see this check.

Results for commit 3c5f29f. ± Comparison against base commit a6010b2.

This pull request removes 5788 tests.
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

@andrewheard
Copy link
Collaborator Author

@davidmotson Would you mind taking over this PR?

@google-oss-bot
Copy link
Contributor

@andrewheard
Copy link
Collaborator Author

Closing in favour of #6932.

@andrewheard andrewheard closed this May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants