-
Notifications
You must be signed in to change notification settings - Fork 617
wip: Schema.fromEnum() #6968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
thatfiredev
wants to merge
2
commits into
main
Choose a base branch
from
rpf/schema-from-enum
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
wip: Schema.fromEnum() #6968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/ai/type/Schema.Companion.html 2025-05-19 16:47:23.452391102 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/ai/type/Schema.Companion.html 2025-05-19 16:43:43.222745074 +0000
@@ -48,6 +48,20 @@
<tr>
<td><code>static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a></code></td>
<td>
+ <div><code><E extends <a href="https://developer.android.com/reference/kotlin/java/lang/Enum.html">Enum</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> E>> <a href="/docs/reference/android/com/google/firebase/ai/type/Schema.Companion.html#fromEnum(kotlin.String,kotlin.Boolean)">fromEnum</a>(<a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> description, boolean nullable)</code></div>
+ <p>Returns a <code><a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a></code> for the given Kotlin Enum.</p>
+ </td>
+ </tr>
+ <tr>
+ <td><code>static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a></code></td>
+ <td>
+ <div><code><E extends <a href="https://developer.android.com/reference/kotlin/java/lang/Enum.html">Enum</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> E>> <a href="/docs/reference/android/com/google/firebase/ai/type/Schema.Companion.html#fromEnum(java.lang.Class,kotlin.String,kotlin.Boolean)">fromEnum</a>(<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Class.html">Class</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> E> enumClass,<br> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> description,<br> boolean nullable<br>)</code></div>
+ <p>Returns a <code><a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a></code> for the given Java Enum.</p>
+ </td>
+ </tr>
+ <tr>
+ <td><code>static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a></code></td>
+ <td>
<div><code><a href="/docs/reference/android/com/google/firebase/ai/type/Schema.Companion.html#numDouble(kotlin.String,kotlin.Boolean)">numDouble</a>(<a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> description, boolean nullable)</code></div>
<p>Returns a <code><a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a></code> for a double-precision floating-point number.</p>
</td>
@@ -187,6 +201,80 @@
</td>
</tr>
<tr>
+ <td><code><a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> description</code></td>
+ <td>
+ <p>The description of what the parameter should contain or represent</p>
+ </td>
+ </tr>
+ <tr>
+ <td><code>boolean nullable</code></td>
+ <td>
+ <p>Indicates whether the value can be <code>null</code>. Defaults to <code>false</code>.</p>
+ </td>
+ </tr>
+ </tbody>
+ </table>
+ </div>
+ </div>
+ <div class="api-item"><a name="fromEnum(kotlin.String, kotlin.Boolean)"></a><a name="fromEnum-kotlin.String-kotlin.Boolean-"></a><a name="fromenum"></a>
+ <h3 class="api-name" id="fromEnum(kotlin.String,kotlin.Boolean)">fromEnum</h3>
+ <pre class="api-signature no-pretty-print">public static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a> <E extends <a href="https://developer.android.com/reference/kotlin/java/lang/Enum.html">Enum</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> E>> <a href="/docs/reference/android/com/google/firebase/ai/type/Schema.Companion.html#fromEnum(kotlin.String,kotlin.Boolean)">fromEnum</a>(<a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> description, boolean nullable)</pre>
+ <p>Returns a <code><a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a></code> for the given Kotlin Enum.</p>
+ <p>For example, the cardinal directions can be represented as:</p>
+ <pre class="prettyprint">enum class CardinalDirection { NORTH, EAST, SOUTH, WEST }<br><br>Schema.fromEnum<CardinalDirection>()</pre>
+ <div class="devsite-table-wrapper">
+ <table class="responsive">
+ <colgroup>
+ <col width="40%">
+ <col>
+ </colgroup>
+ <thead>
+ <tr>
+ <th colspan="100%">Parameters</th>
+ </tr>
+ </thead>
+ <tbody class="list">
+ <tr>
+ <td><code><a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> description</code></td>
+ <td>
+ <p>The description of what the parameter should contain or represent</p>
+ </td>
+ </tr>
+ <tr>
+ <td><code>boolean nullable</code></td>
+ <td>
+ <p>Indicates whether the value can be <code>null</code>. Defaults to <code>false</code>.</p>
+ </td>
+ </tr>
+ </tbody>
+ </table>
+ </div>
+ </div>
+ <div class="api-item"><a name="fromEnum(java.lang.Class, kotlin.String, kotlin.Boolean)"></a><a name="fromEnum-java.lang.Class-kotlin.String-kotlin.Boolean-"></a><a name="fromenum"></a>
+ <h3 class="api-name" id="fromEnum(java.lang.Class,kotlin.String,kotlin.Boolean)">fromEnum</h3>
+ <pre class="api-signature no-pretty-print">public static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a> <E extends <a href="https://developer.android.com/reference/kotlin/java/lang/Enum.html">Enum</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> E>> <a href="/docs/reference/android/com/google/firebase/ai/type/Schema.Companion.html#fromEnum(java.lang.Class,kotlin.String,kotlin.Boolean)">fromEnum</a>(<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Class.html">Class</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> E> enumClass,<br> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> description,<br> boolean nullable<br>)</pre>
+ <p>Returns a <code><a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a></code> for the given Java Enum.</p>
+ <p>For example, the cardinal directions can be represented as:</p>
+ <pre class="prettyprint">enum CardinalDirection { NORTH, EAST, SOUTH, WEST }<br><br>Schema.fromEnum(CardinalDirection.class);</pre>
+ <div class="devsite-table-wrapper">
+ <table class="responsive">
+ <colgroup>
+ <col width="40%">
+ <col>
+ </colgroup>
+ <thead>
+ <tr>
+ <th colspan="100%">Parameters</th>
+ </tr>
+ </thead>
+ <tbody class="list">
+ <tr>
+ <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Class.html">Class</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> E> enumClass</code></td>
+ <td>
+ <p>The Enum's Java class.</p>
+ </td>
+ </tr>
+ <tr>
<td><code><a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> description</code></td>
<td>
<p>The description of what the parameter should contain or represent</p> --- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/ai/type/Schema.html 2025-05-19 16:47:23.441391122 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/ai/type/Schema.html 2025-05-19 16:43:43.208745096 +0000
@@ -148,6 +148,13 @@
<tr>
<td><code>static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a></code></td>
<td>
+ <div><code><E extends <a href="https://developer.android.com/reference/kotlin/java/lang/Enum.html">Enum</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> E>> <a href="/docs/reference/android/com/google/firebase/ai/type/Schema.Companion.html#fromEnum(java.lang.Class,kotlin.String,kotlin.Boolean)">fromEnum</a>(<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Class.html">Class</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> E> enumClass,<br> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> description,<br> boolean nullable<br>)</code></div>
+ <p>Returns a <code><a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a></code> for the given Java Enum.</p>
+ </td>
+ </tr>
+ <tr>
+ <td><code>static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a></code></td>
+ <td>
<div><code><a href="/docs/reference/android/com/google/firebase/ai/type/Schema.Companion.html#integer(kotlin.String,kotlin.Boolean)">integer</a>(<a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> description, boolean nullable)</code></div>
<p>Returns a <code><a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a></code> for a 32-bit signed integer number.</p>
</td>
@@ -379,6 +386,46 @@
</td>
</tr>
<tr>
+ <td><code>boolean nullable</code></td>
+ <td>
+ <p>Indicates whether the value can be <code>null</code>. Defaults to <code>false</code>.</p>
+ </td>
+ </tr>
+ </tbody>
+ </table>
+ </div>
+ </div>
+ <div class="api-item"><a name="fromEnum(java.lang.Class, kotlin.String, kotlin.Boolean)"></a><a name="fromEnum-java.lang.Class-kotlin.String-kotlin.Boolean-"></a><a name="fromenum"></a>
+ <h3 class="api-name" id="fromEnum(java.lang.Class,kotlin.String,kotlin.Boolean)">fromEnum</h3>
+ <pre class="api-signature no-pretty-print">public static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a> <E extends <a href="https://developer.android.com/reference/kotlin/java/lang/Enum.html">Enum</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> E>> <a href="/docs/reference/android/com/google/firebase/ai/type/Schema.Companion.html#fromEnum(java.lang.Class,kotlin.String,kotlin.Boolean)">fromEnum</a>(<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Class.html">Class</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> E> enumClass,<br> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> description,<br> boolean nullable<br>)</pre>
+ <p>Returns a <code><a href="/docs/reference/android/com/google/firebase/ai/type/Schema.html">Schema</a></code> for the given Java Enum.</p>
+ <p>For example, the cardinal directions can be represented as:</p>
+ <pre class="prettyprint">enum CardinalDirection { NORTH, EAST, SOUTH, WEST }<br><br>Schema.fromEnum(CardinalDirection.class);</pre>
+ <div class="devsite-table-wrapper">
+ <table class="responsive">
+ <colgroup>
+ <col width="40%">
+ <col>
+ </colgroup>
+ <thead>
+ <tr>
+ <th colspan="100%">Parameters</th>
+ </tr>
+ </thead>
+ <tbody class="list">
+ <tr>
+ <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Class.html">Class</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> E> enumClass</code></td>
+ <td>
+ <p>The Enum's Java class.</p>
+ </td>
+ </tr>
+ <tr>
+ <td><code><a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> description</code></td>
+ <td>
+ <p>The description of what the parameter should contain or represent</p>
+ </td>
+ </tr>
+ <tr>
<td><code>boolean nullable</code></td>
<td>
<p>Indicates whether the value can be <code>null</code>. Defaults to <code>false</code>.</p> --- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/ai/type/Schema.html 2025-05-19 16:47:23.475391059 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/ai/type/Schema.html 2025-05-19 16:43:43.248745034 +0000
@@ -63,6 +63,20 @@
</td>
</tr>
<tr>
+ <td><code>inline <a href="/docs/reference/kotlin/com/google/firebase/ai/type/Schema.html">Schema</a></code></td>
+ <td>
+ <div><code><E : <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-enum/index.html">Enum</a><E>> <a href="/docs/reference/kotlin/com/google/firebase/ai/type/Schema.Companion.html#fromEnum(kotlin.String,kotlin.Boolean)">fromEnum</a>(description: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>?, nullable: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a>)</code></div>
+ <p>Returns a <code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/Schema.html">Schema</a></code> for the given Kotlin Enum.</p>
+ </td>
+ </tr>
+ <tr>
+ <td><code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/Schema.html">Schema</a></code></td>
+ <td>
+ <div><code><E : <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-enum/index.html">Enum</a><E>> <a href="/docs/reference/kotlin/com/google/firebase/ai/type/Schema.Companion.html#fromEnum(java.lang.Class,kotlin.String,kotlin.Boolean)">fromEnum</a>(<br> enumClass: <a href="https://developer.android.com/reference/kotlin/java/lang/Class.html">Class</a><E>,<br> description: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>?,<br> nullable: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a><br>)</code></div>
+ <p>Returns a <code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/Schema.html">Schema</a></code> for the given Java Enum.</p>
+ </td>
+ </tr>
+ <tr>
<td><code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/Schema.html">Schema</a></code></td>
<td>
<div><code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/Schema.Companion.html#integer(kotlin.String,kotlin.Boolean)">integer</a>(description: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>?, nullable: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a>)</code></div>
@@ -324,6 +338,80 @@
</td>
</tr>
<tr>
+ <td><code>nullable: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a> = false</code></td>
+ <td>
+ <p>Indicates whether the value can be <code>null</code>. Defaults to <code>false</code>.</p>
+ </td>
+ </tr>
+ </tbody>
+ </table>
+ </div>
+ </div>
+ <div class="api-item"><a name="fromEnum(kotlin.String, kotlin.Boolean)"></a><a name="fromEnum-kotlin.String-kotlin.Boolean-"></a><a name="fromenum"></a>
+ <h3 class="api-name" id="fromEnum(kotlin.String,kotlin.Boolean)">fromEnum</h3>
+ <pre class="api-signature no-pretty-print">inline fun <E : <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-enum/index.html">Enum</a><E>> <a href="/docs/reference/kotlin/com/google/firebase/ai/type/Schema.Companion.html#fromEnum(kotlin.String,kotlin.Boolean)">fromEnum</a>(description: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>? = null, nullable: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a> = false): <a href="/docs/reference/kotlin/com/google/firebase/ai/type/Schema.html">Schema</a></pre>
+ <p>Returns a <code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/Schema.html">Schema</a></code> for the given Kotlin Enum.</p>
+ <p>For example, the cardinal directions can be represented as:</p>
+ <pre class="prettyprint">enum class CardinalDirection { NORTH, EAST, SOUTH, WEST }<br><br>Schema.fromEnum<CardinalDirection>()</pre>
+ <div class="devsite-table-wrapper">
+ <table class="responsive">
+ <colgroup>
+ <col width="40%">
+ <col>
+ </colgroup>
+ <thead>
+ <tr>
+ <th colspan="100%">Parameters</th>
+ </tr>
+ </thead>
+ <tbody class="list">
+ <tr>
+ <td><code>description: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>? = null</code></td>
+ <td>
+ <p>The description of what the parameter should contain or represent</p>
+ </td>
+ </tr>
+ <tr>
+ <td><code>nullable: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a> = false</code></td>
+ <td>
+ <p>Indicates whether the value can be <code>null</code>. Defaults to <code>false</code>.</p>
+ </td>
+ </tr>
+ </tbody>
+ </table>
+ </div>
+ </div>
+ <div class="api-item"><a name="fromEnum(java.lang.Class, kotlin.String, kotlin.Boolean)"></a><a name="fromEnum-java.lang.Class-kotlin.String-kotlin.Boolean-"></a><a name="fromenum"></a>
+ <h3 class="api-name" id="fromEnum(java.lang.Class,kotlin.String,kotlin.Boolean)">fromEnum</h3>
+ <pre class="api-signature no-pretty-print">fun <E : <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-enum/index.html">Enum</a><E>> <a href="/docs/reference/kotlin/com/google/firebase/ai/type/Schema.Companion.html#fromEnum(java.lang.Class,kotlin.String,kotlin.Boolean)">fromEnum</a>(<br> enumClass: <a href="https://developer.android.com/reference/kotlin/java/lang/Class.html">Class</a><E>,<br> description: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>? = null,<br> nullable: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a> = false<br>): <a href="/docs/reference/kotlin/com/google/firebase/ai/type/Schema.html">Schema</a></pre>
+ <p>Returns a <code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/Schema.html">Schema</a></code> for the given Java Enum.</p>
+ <p>For example, the cardinal directions can be represented as:</p>
+ <pre class="prettyprint">enum CardinalDirection { NORTH, EAST, SOUTH, WEST }<br><br>Schema.fromEnum(CardinalDirection.class);</pre>
+ <div class="devsite-table-wrapper">
+ <table class="responsive">
+ <colgroup>
+ <col width="40%">
+ <col>
+ </colgroup>
+ <thead>
+ <tr>
+ <th colspan="100%">Parameters</th>
+ </tr>
+ </thead>
+ <tbody class="list">
+ <tr>
+ <td><code>enumClass: <a href="https://developer.android.com/reference/kotlin/java/lang/Class.html">Class</a><E></code></td>
+ <td>
+ <p>The Enum's Java class.</p>
+ </td>
+ </tr>
+ <tr>
+ <td><code>description: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>? = null</code></td>
+ <td>
+ <p>The description of what the parameter should contain or represent</p>
+ </td>
+ </tr>
+ <tr>
<td><code>nullable: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a> = false</code></td>
<td>
<p>Indicates whether the value can be <code>null</code>. Defaults to <code>false</code>.</p> |
Generated by 🚫 Danger |
Coverage Report 1Affected ProductsNo changes between base commit (f2257e4) and merge commit (ad6f5a7).Test Logs |
Test Results 22 files - 44 22 suites - 44 37s ⏱️ -39s Results for commit 85f1ce5. ± Comparison against base commit f2257e4. This pull request removes 552 and adds 104 tests. Note that renamed tests count towards both.
|
Size Report 1Affected Products
Test Logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.