Skip to content

Update v2 rtdb to expose RawRTDBEvent and RawRTDBCloudEventData #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

TheIronDev
Copy link
Contributor

This commit updates the v2 database provider to also expose the
RawRTDB Events.

This will be used in test-sdk when mocking returned DatabaseEvents.

This commit updates the v2 database provider to also expose the
RawRTDB Events.

This will be used in test-sdk when mocking returned DatabaseEvents.
@TheIronDev TheIronDev requested a review from colerogers June 15, 2022 16:28
Copy link
Contributor

@colerogers colerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we throw @hidden on the interfaces to keep them out of doc?

@TheIronDev
Copy link
Contributor Author

Good catch! Updated!

@TheIronDev TheIronDev merged commit 76e0afd into master Jun 15, 2022
inlined added a commit that referenced this pull request Jun 16, 2022
* Bump admin SDK version. Remove vendored APIs + sniffing

* Bump node version; remove tests for old node versions

* Package lock

* Update v2 rtdb to expose RawRTDBEvent and RawRTDBCloudEventData (#1137)

* Update v2 rtdb to expose RawRTDBEvent and RawRTDBCloudEventData

This commit updates the v2 database provider to also expose the
RawRTDB Events.

This will be used in test-sdk when mocking returned DatabaseEvents.

* Adding @hidden instead of @internal

* Revert package lock

* Run formatter

Co-authored-by: Tyler Stark <[email protected]>
inlined added a commit that referenced this pull request Jun 26, 2022
* Update v2 rtdb to expose RawRTDBEvent and RawRTDBCloudEventData (#1137)

* Update v2 rtdb to expose RawRTDBEvent and RawRTDBCloudEventData

This commit updates the v2 database provider to also expose the
RawRTDB Events.

This will be used in test-sdk when mocking returned DatabaseEvents.

* Adding @hidden instead of @internal

* Put tests in a codebase

* Revert changes to package-lock.json

* Format fix

Co-authored-by: Tyler Stark <[email protected]>
Co-authored-by: Daniel Young Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants