Make event params strongly typed #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlined
force-pushed
the
inlined.typed-params
branch
from
4042731 to
801a7b8
Compare
colerogers
reviewed
Jul 14, 2022
taeold
approved these changes
Aug 22, 2022
spec/common/params.spec.ts
Outdated
Comment on lines
78
to
84
| it('falls back to Record<string, string> without better type info', () => { | ||
| expectType<ParamsOf<string>>({} as Record<string, string>); | ||
| }); | ||
|
|
||
| it('is the empty object when there are no params', () => { | ||
| expectType<ParamsOf<string>>({} as Record<string, never>); | ||
| }); |
There was a problem hiding this comment.
q: How does these two test case (which look identical to me) both pass 🤔 ?
ParamsOf<string> is both Record<string, string> and Record<string, never>?
Merged
taeold
added a commit
that referenced
this pull request
Aug 23, 2022
Integration test caught some bugs! 1. From #1155 - Some internal type must be exposed - otherwise compiling user projects fails w/ error message like below: ``` Error: node_modules/firebase-functions/lib/common/params.d.ts(10,13): error TS2314: Generic type 'Extract' requires 2 type argument(s). Error: node_modules/firebase-functions/lib/common/params.d.ts(10,21): error TS2304: Cannot find name 'Split'. Error: node_modules/firebase-functions/lib/common/params.d.ts(10,27): error TS2304: Cannot find name 'NullSafe'. ``` 2. From #1181 - There is no way to call private callable functions since GCF requrie GCP identity token as authorization header while callable function requires Firebase auth tokens. Disabling those test cases in the integration test until we can mint a GCP project w/ permission to create public functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements go/cf3-typed-params.
WIP: currently only common and v2 are implemented.
Had to update
prettierto the next major version so it could read TS 4.1 features without erroring out. I created #1160 as a base for this change to make it easier to separate mechanical from hand-crafted changes. If this is approved, however, I'll commit both changes tolaunch.next