Skip to content

Fix namespace v1 docs #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 24, 2022
Merged

Fix namespace v1 docs #1204

merged 7 commits into from
Aug 24, 2022

Conversation

colerogers
Copy link
Contributor

@colerogers colerogers commented Aug 24, 2022

  • analytics
  • config
  • https
  • pubsub
  • runnable
  • storage

@colerogers colerogers changed the base branch from master to launch.next August 24, 2022 17:29
@colerogers colerogers changed the title Colerogers.docs bugbash Fix namespace v1 docs Aug 24, 2022
@colerogers colerogers marked this pull request as ready for review August 24, 2022 18:21
Copy link
Contributor

@TheIronDev TheIronDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@colerogers colerogers merged commit d12b1d1 into launch.next Aug 24, 2022
constructor(private triggerResource: () => string, private options: DeploymentOptions) {}

/** @hidden */
/** @internal */
onChange(): Error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this in launch.next?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 #1220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants