Skip to content

allow Expressions in the top-level configuration of v1 functions #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

Berlioz
Copy link
Contributor

@Berlioz Berlioz commented Sep 30, 2022

No description provided.

@Berlioz Berlioz requested a review from taeold September 30, 2022 19:09
Copy link
Member

@inlined inlined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we only changing three options? At very least we need to change secrets to support an Array<string | SecretParam>

@Berlioz Berlioz merged commit 9332ea0 into launch.next Oct 4, 2022
Berlioz added a commit that referenced this pull request Oct 4, 2022
Berlioz added a commit that referenced this pull request Oct 4, 2022
@Berlioz
Copy link
Contributor Author

Berlioz commented Oct 4, 2022

Gaaaack. Wrong PR. At least launch.next being unprotected meant I could revert the click immediately.

@Berlioz Berlioz mentioned this pull request Oct 5, 2022
@taeold taeold added this to the v4 milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants