Skip to content

Remove manifest types from API. #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/params/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -426,17 +426,3 @@ export class BooleanParam extends Param<boolean> {
return new TernaryExpression(this, ifTrue, ifFalse);
}
}

/** @hidden */
export class ListParam extends Param<string[]> {
static type: ParamValueType = "list";

/** @internal */
runtimeValue(): string[] {
throw new Error("Not implemented");
}

toSpec(): WireParamSpec<string[]> {
throw new Error("Not implemented");
}
}
4 changes: 4 additions & 0 deletions src/runtime/manifest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import { WireParamSpec } from "../params/types";

/**
* An definition of a function as appears in the Manifest.
*
* @internal
*/
export interface ManifestEndpoint {
entryPoint?: string;
Expand Down Expand Up @@ -100,13 +102,15 @@ export interface ManifestEndpoint {
};
}

/** @internal */
export interface ManifestRequiredAPI {
api: string;
reason: string;
}

/**
* An definition of a function deployment as appears in the Manifest.
* @internal
*/
export interface ManifestStack {
specVersion: "v1alpha1";
Expand Down
4 changes: 2 additions & 2 deletions src/v1/providers/tasks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ export interface TaskQueueOptions {
export interface TaskQueueFunction {
(req: Request, res: express.Response): Promise<void>;

/** @alpha */
/** @internal */
__endpoint: ManifestEndpoint;

/** @alpha */
/** @internal */
__requiredAPIs?: ManifestRequiredAPI[];

/**
Expand Down
2 changes: 1 addition & 1 deletion src/v2/core.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export interface CloudEvent<T> {
export interface CloudFunction<EventType extends CloudEvent<unknown>> {
(raw: CloudEvent<unknown>): any | Promise<any>;

/** @alpha */
/** @internal */
__endpoint: ManifestEndpoint;

/**
Expand Down
2 changes: 1 addition & 1 deletion src/v2/providers/https.ts
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ export type HttpsFunction = ((
/** An Express response object, for this function to respond to callers. */
res: express.Response
) => void | Promise<void>) & {
/** @alpha */
/** @internal */
__endpoint: ManifestEndpoint;
};

Expand Down