[FR]: FIROptions init with NSData

[unboxme]

Description

1. We would like to get rid of storing GoogleService-Info.plist in the bundle that is required for Firebase configuration.
2. There is no way to init FIROptions using a content of the GoogleService-Info.plist.
   2.1. -initWithGoogleAppID:GCMSenderID: is not valid due to this.
   2.2. -initWithContentsOfFile: requires to store GoogleService-Info.plist in the bundle.
3. Better to have an initializer of FIROptions with NSData from GoogleService-Info.plist.

This feature should be useful for those who would like to keep the GoogleService-Info.plist data in a more secure way than storing files in the bundle.

API Proposal

Here are snippets to show how it should work.

FIROptions.h

- (nullable instancetype)initWithData:(NSData *)data NS_DESIGNATED_INITIALIZER;

FIROptions.m

- (instancetype)initWithData:(NSData *)data {
  self = [super init];
  if (self) {
    if (data == nil) {
      FIRLogError(kFIRLoggerCore, @"I-COR000013", @"The plist file data is nil.");
      return nil;
    }
    id optionsDictionary = [NSPropertyListSerialization propertyListWithData:data
                                                                     options:NSPropertyListImmutable
                                                                      format:NULL
                                                                       error:NULL];
    if (optionsDictionary == nil || ![optionsDictionary isKindOfClass:[NSDictionary class]]) {
      FIRLogError(kFIRLoggerCore, @"I-COR000014", @"The configuration data is corrupted.");
      return nil;
    }
    _optionsDictionary = [optionsDictionary mutableCopy];
  }
  return self;
}

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[morganchen12]

@unboxme FYI storing the GoogleService-Info.plist values in the form of encrypted data on disk is only obfuscation, it's not really secret as long as you have to decrypt it in your app to initialize Firebase.

[unboxme]

is only obfuscation, it's not really secret as long as you have to decrypt it in your app to initialize Firebase

@morganchen12 Sure. For most developers it is enough, I suppose.

This feature will add just one more step to make ipa-explorer-fan's life a little bit harder.