Skip to content

remove auth-types-exp #4487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 23, 2021
Merged

remove auth-types-exp #4487

merged 15 commits into from
Feb 23, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Feb 18, 2021 •
edited
Loading

TODO

  • update links in comments
  • decide what to do with the abstract classes in public-types.ts
    • removed classes and abstract classes from public-types.ts

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 67208d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1 Feiyang1 changed the title [WIP] remove auth-types-exp remove auth-types-exp Feb 19, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 19, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (08e2aa3) and head commit (46aae46).

Test Logs

sam-gc
sam-gc approved these changes Feb 23, 2021
View reviewed changes
@Feiyang1 Feiyang1 mentioned this pull request Feb 23, 2021
Closed
@Feiyang1 Feiyang1 merged commit 20a88da into master Feb 23, 2021
@Feiyang1 Feiyang1 deleted the fei-rm-auth-exp-types branch February 23, 2021 23:30
@firebase firebase locked and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

Assignees

@sam-gc sam-gc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Feiyang1 @google-oss-bot @sam-gc @hsubox76